qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)


From: Michael S. Tsirkin
Subject: Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)
Date: Wed, 20 Nov 2019 07:04:43 -0500

On Wed, Nov 20, 2019 at 11:41:32AM +0000, Stefan Hajnoczi wrote:
> On Wed, Nov 20, 2019 at 10:37:35AM +0100, Philippe Mathieu-Daudé wrote:
> > On 11/19/19 12:16 PM, Stefan Hajnoczi wrote:
> > > The virtqueue element returned by vu_queue_pop() is allocated using
> > > malloc(3) by virtqueue_alloc_element().  Use the matching free(3)
> > > function instead of glib's g_free().
> > > 
> > > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > 
> > Fixes: 06914c97d3a ?
> 
> Good idea, I should have included that.
> 
> Stefan

I'd prefer keeping the Fixes tag to bugfixes as opposed to cleanups.
I.e. it should be a reasonable heuristic for people asking "do I need
this patch" to be able to answer based on whether they have the
linked patch.

-- 
MST




reply via email to

[Prev in Thread] Current Thread [Next in Thread]