Re: [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] target/i386: add support for MSR_IA32_TSX_CTRL
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
995694e target/i386: add support for MSR_IA32_TSX_CTRL

=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#38: FILE: target/i386/cpu.h:354:
+#define ARCH_CAP_TSX_CTRL_MSR^I^I(1<<7)$

ERROR: spaces required around that '<<' (ctx:VxV)
#38: FILE: target/i386/cpu.h:354:
+#define ARCH_CAP_TSX_CTRL_MSR          (1<<7)
                                          ^

ERROR: code indent should never use tabs
#40: FILE: target/i386/cpu.h:356:
+#define MSR_IA32_TSX_CTRL^I^I0x122$

total: 3 errors, 0 warnings, 101 lines checked

Commit 995694ea43f9 (target/i386: add support for MSR_IA32_TSX_CTRL) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden