[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR |
|
Date: |
Wed, 20 Nov 2019 19:26:02 +0400 |
On Wed, Nov 20, 2019 at 7:24 PM Marc-André Lureau
<address@hidden> wrote:
>
> Hi,
>
> QDEV_PROP_PTR is marked in multiple places as "FIXME/TODO/remove
> me". In most cases, it can be easily replaced with QDEV_PROP_LINK when
> the pointer points to an Object.
>
> There are a few places where such substitution isn't possible. For
> those places, it seems reasonable to use a specific setter method
> instead, and keep the user_creatable = false. In other places,
> proper usage of qdev or other facilies is the solution.
>
> The serial code wasn't converted to qdev, which makes it a bit more
> archaic to deal with. Let's convert it first, so we can more easily
> embed it from other devices, and re-export some properties and drop
> QDEV_PROP_PTR usage.
>
> v4: (after Peter & Philippe reviews)
Please ignore that cover letter, resending with v4 in subject (let's
see how patchew handle that!).