Re: [PATCH v16 13/14] tests/numa: Add case for QMP build HMAT

[Tao Xu]

On 11/20/2019 8:32 PM, Igor Mammedov wrote:
> On Fri, 15 Nov 2019 15:53:51 +0800
> Tao Xu <address@hidden> wrote:
>
> > Check configuring HMAT usecase
> >
> > Suggested-by: Igor Mammedov <address@hidden>
> > Signed-off-by: Tao Xu <address@hidden>
> > ---
> >
> > New patch in v16.
> > ---
> >   tests/numa-test.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 51 insertions(+)
>
> I'd also add X-FAIL variants here, to test fail conditions.
> Taking in account that QMP interface returns error without
> affecting QEMU state, you can do it within one test case without
> restarting it on every fail scenario.
> (just add appropriate comments so reader would know that you are
> testing this and that failure path)
>
> So I'd first test x-fail variants and then finish test with
> valid configuration.

Thank you for your suggestion. I will add it in next version.