Re: [RFC v4 PATCH 19/49] multi-process: configure remote side devices

[Stefan Hajnoczi]

On Thu, Oct 24, 2019 at 05:09:00AM -0400, Jagannathan Raman wrote:
> +static void set_remote_opts(PCIDevice *dev, QDict *qdict, unsigned int cmd)
> +{
> +    QString *qstr;
> +    MPQemuMsg msg;
> +    const char *str;
> +    PCIProxyDev *pdev;
> +
> +    pdev = PCI_PROXY_DEV(dev);
> +
> +    qstr = qobject_to_json(QOBJECT(qdict));

qstr is leaked.

> +    str = qstring_get_str(qstr);
> +
> +    memset(&msg, 0, sizeof(MPQemuMsg));
> +
> +    msg.data2 = (uint8_t *)str;
> +    msg.cmd = cmd;
> +    msg.bytestream = 1;
> +    msg.size = qstring_get_length(qstr) + 1;
> +    msg.num_fds = 0;
> +
> +    mpqemu_msg_send(pdev->mpqemu_link, &msg, pdev->mpqemu_link->com);
> +
> +    return;
> +}

signature.asc
Description: PGP signature