RE: [PATCH] Add minimal Hexagon target - First in a series of patches - linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files in target/hexagon/imported are from another project and therefore do not conform to qemu coding standards

[Taylor Simpson]

They are imported from the existing Hexagon simulator.  Please understand that 
this patch is the first in a series.  Later patches will contain more elaborate 
contents in that directory.  The reason I don't want to reformat them is to 
stay in sync with the other simulator in the future.  When the other team makes 
changes to the code (either to fix bugs or add features), it will be easier to 
identify the changes and bring them into qemu.

Taylor

-----Original Message-----
From: Aleksandar Markovic <address@hidden>
Sent: Thursday, November 21, 2019 1:20 PM
To: Taylor Simpson <address@hidden>
Cc: Laurent Vivier <address@hidden>; Riku Voipio <address@hidden>; QEMU 
Developers <address@hidden>
Subject: Re: [PATCH] Add minimal Hexagon target - First in a series of patches 
- linux-user changes + linux-user/hexagon + skeleton of target/hexagon - Files 
in target/hexagon/imported are from another project and therefore do not 
conform to qemu coding standards


>  create mode 100644 target/hexagon/imported/global_types.h
>  create mode 100644 target/hexagon/imported/iss_ver_registers.h
>  create mode 100644 target/hexagon/imported/max.h  create mode 100644
> target/hexagon/imported/regs.h

Taylor, if I understood you well, these files don't confirm to QEMU coding 
standard, because they are imported. But, from where? And what is the reason 
they need to be imported (and not created independently by you or somebody 
else, but within QEMU code style guidelines) ?
Their content looks fairly simple to me.

Thanks,
Aleksandar