qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] target/arm: Fix ISR_EL1 tracking when executing at EL2
Date: Fri, 22 Nov 2019 16:34:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/22/19 3:16 PM, Peter Maydell wrote:
On Fri, 22 Nov 2019 at 13:59, Marc Zyngier <address@hidden> wrote:

The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1,
ISR_EL1 shows the pending status of the physical IRQ, FIQ, or
SError interrupts.

Unfortunately, QEMU's implementation only considers the HCR_EL2
bits, and ignores the current exception level. This means a hypervisor
trying to look at its own interrupt state actually sees the guest
state, which is unexpected and breaks KVM as of Linux 5.3.

Instead, check for the running EL and return the physical bits
if not running in a virtualized context.

Fixes: 636540e9c40b
Reported-by: Quentin Perret <address@hidden>
Signed-off-by: Marc Zyngier <address@hidden>

Congratulations on your first QEMU patch :-)

:))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]