[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core
From: |
Aleksandar Markovic |
Subject: |
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic |
Date: |
Fri, 22 Nov 2019 17:58:53 +0100 |
> +/* Number of CPU registers */
> +#define NO_CPU_REGISTERS 32
> +/* Number of IO registers accessible by ld/st/in/out */
> +#define NO_IO_REGISTERS 64
Hi again, Michael. :)
May I ask you to do a global replace of names of these two constants
to CPU_REGISTERS_COUNT / IO_REGISTERS_COUNT or NUMBER_OF_CPU_REGISTERS
/ NUMBER_OF_IO_REGISTERS, or whatever else you find suitable (the
reason being "NO_" is visually/perceptually very confusing - many
readers would have first impression that it means a negative ("no"),
not a "number of" as you, for sure, want.
Thanks,
Aleksandar
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, (continued)
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Richard Henderson, 2019/11/22
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Aleksandar Markovic, 2019/11/22
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Philippe Mathieu-Daudé, 2019/11/22
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Michael Rolnik, 2019/11/22
- Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Philippe Mathieu-Daudé, 2019/11/22
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Aleksandar Markovic, 2019/11/21
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic,
Aleksandar Markovic <=
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Aleksandar Markovic, 2019/11/22
Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic, Aleksandar Markovic, 2019/11/22