Re: [PATCH v3 8/8] iotests: Test committing to short backing file

[Eric Blake]

On 11/22/19 10:05 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>   tests/qemu-iotests/274        | 152 +++++++++++++++++++++++++
>   tests/qemu-iotests/274.out    | 203 ++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/group      |   1 +
>   tests/qemu-iotests/iotests.py |   2 +-
>   4 files changed, 357 insertions(+), 1 deletion(-)
>   create mode 100755 tests/qemu-iotests/274
>   create mode 100644 tests/qemu-iotests/274.out

> +    iotests.log('== Resize tests ==')
> +
> +    # Use different sizes for different allocation modes:
> +    #
> +    # We want to have at least one test where 32 bit truncation in the size of
> +    # the overlapping area becomes visible. This is covered by the
> +    # prealloc='off' case (1G to 6G is an overlap of 5G).
> +    #
> +    # However, we can only do this for modes that don't preallocate data
> +    # because otherwise we might run out of space on the test host.
> +    for (prealloc, base_size, top_size_old, top_size_new, off)  in [
> +            ('off',       '6G',  '1G',  '8G',  '5G'),
> +            ('metadata', '32G', '30G', '33G', '31G'),
> +            ('falloc',   '10M',  '5M', '15M',  '9M'),
> +            ('full',     '16M',  '8M', '12M', '11M')]:

The changes since v3 make sense.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org