qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v36 16/17] target/avr: Add Avocado test


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v36 16/17] target/avr: Add Avocado test
Date: Wed, 27 Nov 2019 00:14:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

Hi Michael,

On 11/24/19 6:02 AM, Michael Rolnik wrote:
The test is based on
https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo
demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out.
it also demostrates that timer and IRQ are working

Signed-off-by: Michael Rolnik <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Acked-by: Thomas Huth <address@hidden>
---
  tests/acceptance/machine_avr6.py | 36 ++++++++++++++++++++++++++++++++
  1 file changed, 36 insertions(+)
  create mode 100644 tests/acceptance/machine_avr6.py

diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py
new file mode 100644
index 0000000000..0601080b01
--- /dev/null
+++ b/tests/acceptance/machine_avr6.py
@@ -0,0 +1,36 @@
+import logging
+import time
+import distutils.spawn
+
+from avocado import skipUnless

^ not used, can be dropped

+from avocado_qemu import Test

^ OK

+from avocado.utils import process

^ not used, can be dropped

+
+class AVR6Machine(Test):
+    timeout = 5
+
+    def test_freertos(self):
+        """
+        :avocado: tags=arch:avr
+        :avocado: tags=machine:sample
+        """
+        """
+        
https://github.com/seharris/qemu-avr-tests/raw/master/free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf

As a short documentation, maybe refer to the main.c file instead?

https://github.com/seharris/qemu-avr-tests/blob/36c3e67b8755dcf37e06af6730ef5d477b8ed16d/free-rtos/Demo/AVR_ATMega2560_GCC/main.c

+        constantly prints out 
'ABCDEFGHIJKLMNOPQRSTUVWXABCDEFGHIJKLMNOPQRSTUVWX'
+        """
+        rom_url = 'https://github.com/seharris/qemu-avr-tests'
+        rom_url += '/raw/master/free-rtos/Demo/AVR_ATMega2560_GCC/demo.elf'

Please use the commit sha1 instead of 'master', because Sarah might push a new reference to /master, while the commit sha1 stays constant:

           rom_url = ('https://github.com/seharris/qemu-avr-tests'
                      '/raw/36c3e67b8755dcf/free-rtos/Demo'
                      '/AVR_ATMega2560_GCC/demo.elf')

+        rom_hash = '7eb521f511ca8f2622e0a3c5e8dd686efbb911d4'
+        rom_path = self.fetch_asset(rom_url, asset_hash=rom_hash)
+
+        self.vm.set_machine('sample')
+        self.vm.add_args('-bios', rom_path)
+        self.vm.add_args('-nographic')
+        self.vm.launch()
+
+        time.sleep(2)
+        self.vm.shutdown()
+
+        match = 'ABCDEFGHIJKLMNOPQRSTUVWXABCDEFGHIJKLMNOPQRSTUVWX'
+
+        self.assertIn(match, self.vm.get_log())





reply via email to

[Prev in Thread] Current Thread [Next in Thread]