|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [PATCH v37 00/17] QEMU AVR 8 bit cores |
| Date: | Thu, 28 Nov 2019 15:16:28 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 11/28/19 2:46 PM, Michael Rolnik wrote:
I will rename them.
Please wait comments from Richard before a version respin.
On Thu, Nov 28, 2019 at 3:41 PM Aleksandar Markovic <address@hidden <mailto:address@hidden>> wrote:
[...]
If I understand Aleksandar correctly, the naming is incorrect
because too generic to AVR family, why Sarah only modeled the
Atmel implementation.
Renaming devices such hw/char/avr_usart.c ->
hw/char/atmel_usart.c (similarly with the macros) would be
enough Aleksandar?
Some renaming could help, perhaps not quite like the one above, but
my point (which I find hard to believe I can't explain to you) is
that peripherals inside the chip evolved over time, as starkly
opposed to external peripherals that are set in stone...
| [Prev in Thread] | Current Thread | [Next in Thread] |