Re: [PULL 0/5] i386 patches for QEMU 4.2-rc

[Jens Freimann]

On Wed, Nov 27, 2019 at 09:14:01AM +0000, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (address@hidden) wrote:
> > On 11/26/19 10:19 AM, address@hidden wrote:
> > > Patchew URL: https://patchew.org/QEMU/address@hidden/
> > >
> > > This series failed the docker-quick@centos7 build test. Please find the 
> > testing commands and
> > > their output below. If you have Docker installed, you can probably reproduce 
> > it
> > > locally.
> > >
> > > === TEST SCRIPT BEGIN ===
> > > #!/bin/bash
> > > make docker-image-centos7 V=1 NETWORK=1
> > > time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
> > > === TEST SCRIPT END ===
> > >
> > >    TEST    check-unit: tests/test-thread-pool
> > > wait_for_migration_fail: unexpected status status=wait-unplug allow_active=1
> > > **
> > > ERROR:/tmp/qemu-test/src/tests/migration-test.c:908:wait_for_migration_fail: 
> > assertion failed: (result)
> > > ERROR - Bail out! 
> > ERROR:/tmp/qemu-test/src/tests/migration-test.c:908:wait_for_migration_fail: 
> > assertion failed: (result)
> > > make: *** [check-qtest-aarch64] Error 1
> >
> > Should we worry about this error?
>
> Interesting; that should be fixed by Jens'
> 284f42a520cd9f5905abac2fa50397423890de8f - unless fix dev_unplug_pending
> is still lying;  it's showing we're still landing in 'wait-unplug' on
> aarch, because it's got a virtio-net by default; even though we've not
> got a failover device setup.  CCing Jens.

I've run this test  on aarch64 in a loop today for a few hours but could not
reproduce this error.

One bug I found is that in primary_unplug_device() I look at the
virtio guest feature bits instead of the negotiated bits. But I don't
think this could lead to the above problem because even if the check
for the feature bit fails, primary_unplug_pending would still return
false because no primary device was set and n->primary_dev is NULL. 

I'll keep the test running until I can reproduce it. 

regards
Jens