[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() |
|
Date: |
Fri, 29 Nov 2019 13:09:10 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <address@hidden> writes:
> 29.11.2019 9:10, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <address@hidden> writes:
>>
>>> No reason for local_err here, use errp directly instead.
>>
>> Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
>> I'm surprised it's just two. Did you search for the anti-pattern
>> systematically?
>
> As I remember - no, only where it breaks automation. Here empty "out: }"
> label will break compilation, if not fixed before or after coccinelle
> run. So, here I fixed it before.
Got it.
A through sweep would be nice, but the goal you're pursuing here
involves more than enough churn already. Don't worry about it now.
[...]