[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 06/21] module: check module wasn't already initialized
From: |
Oleinik, Alexander |
Subject: |
[PATCH v6 06/21] module: check module wasn't already initialized |
Date: |
Fri, 29 Nov 2019 21:34:42 +0000 |
The virtual-device fuzzer must initialize QOM, prior to running
vl:qemu_init, so that it can use the qos_graph to identify the arguments
required to initialize a guest for libqos-assisted fuzzing. This change
prevents errors when vl:qemu_init tries to (re)initialize the previously
initialized QOM module.
Signed-off-by: Alexander Bulekov <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
---
util/module.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/util/module.c b/util/module.c
index e9fe3e5422..841e490e06 100644
--- a/util/module.c
+++ b/util/module.c
@@ -30,6 +30,7 @@ typedef struct ModuleEntry
typedef QTAILQ_HEAD(, ModuleEntry) ModuleTypeList;
static ModuleTypeList init_type_list[MODULE_INIT_MAX];
+static bool modules_init_done[MODULE_INIT_MAX];
static ModuleTypeList dso_init_list;
@@ -91,11 +92,17 @@ void module_call_init(module_init_type type)
ModuleTypeList *l;
ModuleEntry *e;
+ if (modules_init_done[type]) {
+ return;
+ }
+
l = find_type(type);
QTAILQ_FOREACH(e, l, node) {
e->init();
}
+
+ modules_init_done[type] = true;
}
#ifdef CONFIG_MODULES
--
2.23.0
- [PATCH v6 00/21] Add virtual device fuzzing support, Oleinik, Alexander, 2019/11/29
- [PATCH v6 01/21] softmmu: split off vl.c:main() into main.c, Oleinik, Alexander, 2019/11/29
- [PATCH v6 02/21] libqos: Rename i2c_send and i2c_recv, Oleinik, Alexander, 2019/11/29
- [PATCH v6 07/21] qtest: add in-process incoming command handler, Oleinik, Alexander, 2019/11/29
- [PATCH v6 06/21] module: check module wasn't already initialized,
Oleinik, Alexander <=
- [PATCH v6 04/21] qtest: add qtest_server_send abstraction, Oleinik, Alexander, 2019/11/29
- [PATCH v6 13/21] fuzz: add configure flag --enable-fuzzing, Oleinik, Alexander, 2019/11/29
- [PATCH v6 05/21] libqtest: Add a layer of abstraciton to send/recv, Oleinik, Alexander, 2019/11/29
- [PATCH v6 03/21] fuzz: Add FUZZ_TARGET module type, Oleinik, Alexander, 2019/11/29
- [PATCH v6 09/21] libqos: split qos-test and libqos makefile vars, Oleinik, Alexander, 2019/11/29
- [PATCH v6 11/21] libqtest: make bufwrite rely on the TransportOps, Oleinik, Alexander, 2019/11/29
- [PATCH v6 10/21] libqos: move useful qos-test funcs to qos_external, Oleinik, Alexander, 2019/11/29
- [PATCH v6 14/21] fuzz: Add target/fuzz makefile rules, Oleinik, Alexander, 2019/11/29
- [PATCH v6 15/21] fuzz: add fuzzer skeleton, Oleinik, Alexander, 2019/11/29
- [PATCH v6 21/21] fuzz: add documentation to docs/devel/, Oleinik, Alexander, 2019/11/29