[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: virtiofsd: Where should it live?
From: |
Dr. David Alan Gilbert |
Subject: |
Re: virtiofsd: Where should it live? |
Date: |
Tue, 3 Dec 2019 13:06:04 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Daniel P. Berrangé (address@hidden) wrote:
> On Tue, Dec 03, 2019 at 11:06:44AM +0000, Peter Maydell wrote:
> > On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert <address@hidden> wrote:
> > >
> > > We seem to be coming to the conclusion something that:
> > >
> > > a) It should live in the qemu tree
> > > b) It shouldn't live under contrib
> > > c) We'll create a new top level, i.e. 'daemons'
> > > d) virtiofsd will be daemons/virtiofsd
> > >
> > > Now, somethings I'm less clear on:
> > > e) What else would move into daemons? It was suggested
> > > that if we've got virtiofsd in there, then we should move
> > > libvhost-user - which I understand, but then it's not a
> > > 'daemons'.
> > > Are there any otehr daemons that should move?
> >
> > I like the idea of a new top level directory, but I think
> > 'daemons' is a bit too specific -- for instance it seems to
> > me that qemu-img would be sensible to move out of the root,
> > and that's not a daemon.
>
> Do we really need an extra directory level ?
>
> IIUC, the main point against having $GIT_ROOT/virtiofsd is that
> the root of our repo is quite cluttered already.
>
> Rather than trying to create a multi-level hierarchy which adds
> a debate around naming, why not address the clutter by moving
> *ALL* the .c/.h files out of the root so that we have a flatter
> tree:
>
> $GITROOT
> +- qemu-system
> | +- vl.c
> | +- ...most other files...
This seems like a good idea anyway (are all these files -system not
user?)
> +- qemu-img
> | +- qemu-img.c
> +- qemu-nbd
> | +- qemu-nbd.c
> +- qemu-io
> | +- qemu-io.c
> | +- qemu-io-cmds.c
> +- qemu-bridge-helper
> | ...
> +- qemu-edid
> +- qemu-keymap
> +- qga (already exists)
I'm not seeing how having ~ one directory per file is helping; the
number of entries doesn't drop much.
> Then we can add virtiofsd and other programs at the root with no big
> issue.
Dave
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: virtiofsd: Where should it live?, (continued)
- Re: virtiofsd: Where should it live?, Peter Maydell, 2019/12/02
- Re: virtiofsd: Where should it live?, Markus Armbruster, 2019/12/02
- Re: virtiofsd: Where should it live?, Dr. David Alan Gilbert, 2019/12/03
- Re: virtiofsd: Where should it live?, Peter Maydell, 2019/12/03
- Re: virtiofsd: Where should it live?, Dr. David Alan Gilbert, 2019/12/03
- Re: virtiofsd: Where should it live?, Daniel P . Berrangé, 2019/12/03
- Re: virtiofsd: Where should it live?,
Dr. David Alan Gilbert <=
- Re: virtiofsd: Where should it live?, Markus Armbruster, 2019/12/04
- Re: virtiofsd: Where should it live?, Gerd Hoffmann, 2019/12/04
- Re: virtiofsd: Where should it live?, Kevin Wolf, 2019/12/04
- Re: virtiofsd: Where should it live?, Thomas Huth, 2019/12/04
- Re: virtiofsd: Where should it live?, Eric Blake, 2019/12/04
- Re: virtiofsd: Where should it live?, Dr. David Alan Gilbert, 2019/12/04
- Re: virtiofsd: Where should it live?, Dr. David Alan Gilbert, 2019/12/04
- Re: virtiofsd: Where should it live?, Markus Armbruster, 2019/12/04
- Re: virtiofsd: Where should it live?, Eric Blake, 2019/12/04
Re: virtiofsd: Where should it live?, Christophe de Dinechin, 2019/12/02