qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mod


From: Peter Maydell
Subject: Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.
Date: Wed, 4 Dec 2019 15:11:32 +0000

On Wed, 4 Dec 2019 at 02:15, Jason Wang <address@hidden> wrote:
>
>
> On 2019/11/30 上午12:04, Philippe Mathieu-Daudé wrote:
> > On Fri, Nov 29, 2019 at 4:59 PM Wasim, Bilal <address@hidden> wrote:
> >> Thanks for the pointers philippe.. Is the patch okay to be merged without 
> >> it or do I need to do a re-submission with the updated username ?
> > If there are no review comments on your patch, I think the maintainer
> > taking your patch can fix this details directly, no need to resend.
> >
> >> -----Original Message-----
> >> From: Philippe Mathieu-Daudé [mailto:address@hidden]
> >> Sent: Friday, November 29, 2019 8:38 PM
> >> To: address@hidden; address@hidden
> >> Cc: address@hidden; address@hidden; address@hidden; address@hidden; Wasim, 
> >> Bilal <address@hidden>; address@hidden; Jason Wang <address@hidden>
> >> Subject: Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support 
> >> loopback mode.
> >>
> >> Hi Bilal,
> >>
> >> Cc'ing Jason, the maintainer of network devices.
> >>
> >> On 11/29/19 4:05 PM, address@hidden wrote:
> >>> From: bwasim <address@hidden>
> >> Your git setup misses your 'user.name', you could fix it running:
> >>
> >>     git config user.name "Bilal Wasim"
> >>
> >> (eventually with the --global option).
> >>
> >> The patch looks good otherwise.
> >>
> >> Thanks!
>
>
> Applied with the fix for user.name.

Could you fix up the non-standard block comment formatting too?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]