qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/13] docs/devel/reset.txt: add doc about Resettable inte


From: Damien Hedde
Subject: Re: [PATCH v5 09/13] docs/devel/reset.txt: add doc about Resettable interface
Date: Fri, 6 Dec 2019 16:40:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0


On 11/29/19 8:00 PM, Peter Maydell wrote:
> On Fri, 18 Oct 2019 at 16:07, Damien Hedde <address@hidden> wrote:
>>
>> Signed-off-by: Damien Hedde <address@hidden>
> 
> Subject line still says ".txt".
> 
>> ---
>>
>> Should I add an entry into index.rst ?
> 
> Yes, please.
> 
> I have one substantive comment on this patch: in the
> MyDev example of implementing reset, you make the enter/hold/exit
> functions do the reset of the subclass and then call the
> myclass->parent_phases method. This feels to me like it's the
> wrong way round and the parent class should reset first. Does
> it make any difference to do it this way round?
> 

Not really, I'll update them to what you say.

--
Damien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]