[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/10] arm: allwinner-h3: add Security Identifier device

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 08/10] arm: allwinner-h3: add Security Identifier device
Date: Fri, 6 Dec 2019 17:35:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/6/19 3:27 PM, Peter Maydell wrote:
On Mon, 2 Dec 2019 at 21:10, Niek Linnenbank <address@hidden> wrote:

The Security Identifier device in Allwinner H3 System on Chip
gives applications a per-board unique identifier. This commit
adds support for the Allwinner H3 Security Identifier using
randomized data as input.

If this is a fixed value in hardware, I'm not sure that
having the QEMU model pick a random value is the best
choice. If we just set it to a fixed value in QEMU, is
that going to cause problems?

(Generally it's nice for QEMU to be deterministic, so it
behaves the same way every time you run it. Also if it's
always the same we don't need to bother migrating the
ID value.)

Agreed. Since the identifier is 128-bit, I'd use DEFINE_PROP_UUID() or, to be even safer, DEFINE_PROP_UUID_NODEFAULT().
See how the ipmi-bmc-sim device checks its guid field and fails if unset.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]