[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-user-test: fix a memory leak
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] vhost-user-test: fix a memory leak |
Date: |
Wed, 11 Dec 2019 08:48:14 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 11/12/2019 01:55, address@hidden wrote:
> From: Pan Nengyuan <address@hidden>
>
> Spotted by ASAN.
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Pan Nengyuan <address@hidden>
> ---
> tests/vhost-user-test.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c
> index 91ea373..54be931 100644
> --- a/tests/vhost-user-test.c
> +++ b/tests/vhost-user-test.c
> @@ -717,6 +717,8 @@ static void test_migrate(void *obj, void *arg,
> QGuestAllocator *alloc)
> guint64 size;
>
> if (!wait_for_fds(s)) {
> + g_free(uri);
> + test_server_free(dest);
> return;
> }
>
Don't we need also a g_string_free(dest_cmdline)?
I think it is also missing at the end of the function.
Thanks,
Laurent