[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/10] tests: use g_test_rand_int
From: |
Thomas Huth |
Subject: |
[PULL 10/10] tests: use g_test_rand_int |
Date: |
Thu, 12 Dec 2019 19:54:24 +0100 |
From: Paolo Bonzini <address@hidden>
g_test_rand_int provides a reproducible random integer number, using a
different number seed every time but allowing reproduction using the
--seed command line option. It is thus better suited to tests than
g_random_int or random.
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/ivshmem-test.c | 2 +-
tests/test-bitmap.c | 8 ++++----
tests/test-qga.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
index be9aa92a61..ecda256472 100644
--- a/tests/ivshmem-test.c
+++ b/tests/ivshmem-test.c
@@ -443,7 +443,7 @@ static gchar *mktempshm(int size, int *fd)
while (true) {
gchar *name;
- name = g_strdup_printf("/qtest-%u-%u", getpid(), g_random_int());
+ name = g_strdup_printf("/qtest-%u-%u", getpid(), g_test_rand_int());
*fd = shm_open(name, O_CREAT|O_RDWR|O_EXCL,
S_IRWXU|S_IRWXG|S_IRWXO);
if (*fd > 0) {
diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
index 087e02a26c..2f5b71458a 100644
--- a/tests/test-bitmap.c
+++ b/tests/test-bitmap.c
@@ -22,10 +22,10 @@ static void check_bitmap_copy_with_offset(void)
bmap2 = bitmap_new(BMAP_SIZE);
bmap3 = bitmap_new(BMAP_SIZE);
- bmap1[0] = random();
- bmap1[1] = random();
- bmap1[2] = random();
- bmap1[3] = random();
+ bmap1[0] = g_test_rand_int();
+ bmap1[1] = g_test_rand_int();
+ bmap1[2] = g_test_rand_int();
+ bmap1[3] = g_test_rand_int();
total = BITS_PER_LONG * 4;
/* Shift 115 bits into bmap2 */
diff --git a/tests/test-qga.c b/tests/test-qga.c
index 1ca49bbced..d2b2435bb4 100644
--- a/tests/test-qga.c
+++ b/tests/test-qga.c
@@ -143,7 +143,7 @@ static void qmp_assertion_message_error(const char
*domain,
static void test_qga_sync_delimited(gconstpointer fix)
{
const TestFixture *fixture = fix;
- guint32 v, r = g_random_int();
+ guint32 v, r = g_test_rand_int();
unsigned char c;
QDict *ret;
@@ -186,7 +186,7 @@ static void test_qga_sync_delimited(gconstpointer fix)
static void test_qga_sync(gconstpointer fix)
{
const TestFixture *fixture = fix;
- guint32 v, r = g_random_int();
+ guint32 v, r = g_test_rand_int();
QDict *ret;
/*
--
2.18.1
- [PULL 00/10] Bluetooth removal, and qtest & misc patches, Thomas Huth, 2019/12/12
- [PULL 01/10] hw/arm/nseries: Replace the bluetooth chardev with a "null" chardev, Thomas Huth, 2019/12/12
- [PULL 02/10] hw/usb: Remove the USB bluetooth dongle device, Thomas Huth, 2019/12/12
- [PULL 04/10] Remove libbluetooth / bluez from the CI tests, Thomas Huth, 2019/12/12
- [PULL 05/10] tests: fix modules-test 'duplicate test case' error, Thomas Huth, 2019/12/12
- [PULL 06/10] pseries: disable migration-test if /dev/kvm cannot be used, Thomas Huth, 2019/12/12
- [PULL 07/10] hw/misc/ivshmem: Bury dead legacy INTx code, Thomas Huth, 2019/12/12
- [PULL 08/10] glib: use portable g_setenv(), Thomas Huth, 2019/12/12
- [PULL 09/10] tests/Makefile: Fix check-report.* targets shown in check-help, Thomas Huth, 2019/12/12
- [PULL 10/10] tests: use g_test_rand_int,
Thomas Huth <=
- [PULL 03/10] Remove the core bluetooth code, Thomas Huth, 2019/12/12
- Re: [PULL 00/10] Bluetooth removal, and qtest & misc patches, Peter Maydell, 2019/12/16