[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 34/34] nbd: assert that Error** is not NULL in nbd_iter_channe
From: |
Markus Armbruster |
Subject: |
Re: [PULL 34/34] nbd: assert that Error** is not NULL in nbd_iter_channel_error |
Date: |
Wed, 18 Dec 2019 08:31:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 12/17/19 12:26 AM, Markus Armbruster wrote:
>> From: Vladimir Sementsov-Ogievskiy <address@hidden>
>>
>> All callers of nbd_iter_channel_error() pass the address of a
>> local_err variable, and only call this function if an error has
>> already occurred, using this function to propagate that error.
>> This is already implied by its name (local_err instead of the classic
>> errp), but it is worth additionally stressing this by adding an
>> assertion to make it part of the function contract.
>>
>> The local_err parameter is not here to return information about
>> nbd_iter_channel_error failure. Instead it's assumed to be filled when
>> passed to the function. This is already stressed by its name
>> (local_err, instead of classic errp). Stress it additionally by
>> assertion.
>
> Redundant paragraph, but probably too late to worry about it now that
> we have a pull request.
I'll have to respin anyway. I'll drop the second paragraph.
- [PULL 06/34] exec: Fix file_ram_alloc() error API violations, (continued)
- [PULL 06/34] exec: Fix file_ram_alloc() error API violations, Markus Armbruster, 2019/12/17
- [PULL 15/34] net/net: Clean up variable shadowing in net_client_init(), Markus Armbruster, 2019/12/17
- [PULL 16/34] error: make Error **errp const where it is appropriate, Markus Armbruster, 2019/12/17
- [PULL 28/34] hw/sd: drop extra whitespace in sdhci_sysbus_realize() header, Markus Armbruster, 2019/12/17
- [PULL 19/34] qdev-monitor: make Error **errp const where it is appropriate, Markus Armbruster, 2019/12/17
- [PULL 18/34] vnc: drop Error pointer indirection in vnc_client_io_error, Markus Armbruster, 2019/12/17
- [PULL 23/34] block/snapshot: rename Error ** parameter to more common errp, Markus Armbruster, 2019/12/17
- [PULL 32/34] backends/cryptodev: drop local_err from cryptodev_backend_complete(), Markus Armbruster, 2019/12/17
- [PULL 34/34] nbd: assert that Error** is not NULL in nbd_iter_channel_error, Markus Armbruster, 2019/12/17
- [PULL 30/34] hw/usb: rename Error ** parameter to more common errp, Markus Armbruster, 2019/12/17
- [PULL 21/34] 9pfs: make Error **errp const where it is appropriate, Markus Armbruster, 2019/12/17
- [PULL 17/34] hmp: drop Error pointer indirection in hmp_handle_error, Markus Armbruster, 2019/12/17
- [PULL 27/34] hw/s390x: rename Error ** parameter to more common errp, Markus Armbruster, 2019/12/17
- [PULL 31/34] include/qom/object.h: rename Error ** parameter to more common errp, Markus Armbruster, 2019/12/17
- [PULL 24/34] hw/i386/amd_iommu: rename Error ** parameter to more common errp, Markus Armbruster, 2019/12/17
- [PULL 20/34] ppc: make Error **errp const where it is appropriate, Markus Armbruster, 2019/12/17
- [PULL 12/34] error: Clean up unusual names of Error * variables, Markus Armbruster, 2019/12/17
- [PULL 22/34] hw/core/qdev: cleanup Error ** variables, Markus Armbruster, 2019/12/17