qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 38/86] arm:xlnx-versal-virt: use memdev for RAM


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 38/86] arm:xlnx-versal-virt: use memdev for RAM
Date: Tue, 31 Dec 2019 17:05:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/31/19 2:03 PM, Igor Mammedov wrote:
memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
   MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

---
  hw/arm/xlnx-versal-virt.c | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
index 462493c..c137ff4 100644
--- a/hw/arm/xlnx-versal-virt.c
+++ b/hw/arm/xlnx-versal-virt.c
@@ -30,7 +30,6 @@ typedef struct VersalVirt {
      MachineState parent_obj;
Versal soc;
-    MemoryRegion mr_ddr;
void *fdt;
      int fdt_size;
@@ -414,12 +413,9 @@ static void versal_virt_init(MachineState *machine)
          psci_conduit = QEMU_PSCI_CONDUIT_SMC;
      }
- memory_region_allocate_system_memory(&s->mr_ddr, NULL, "ddr",
-                                         machine->ram_size);
-
      sysbus_init_child_obj(OBJECT(machine), "xlnx-ve", &s->soc,
                            sizeof(s->soc), TYPE_XLNX_VERSAL);
-    object_property_set_link(OBJECT(&s->soc), OBJECT(&s->mr_ddr),
+    object_property_set_link(OBJECT(&s->soc), OBJECT(machine->ram),
                               "ddr", &error_abort);
      object_property_set_int(OBJECT(&s->soc), psci_conduit,
                              "psci-conduit", &error_abort);
@@ -473,6 +469,7 @@ static void versal_virt_machine_class_init(ObjectClass *oc, 
void *data)
      mc->max_cpus = XLNX_VERSAL_NR_ACPUS;
      mc->default_cpus = XLNX_VERSAL_NR_ACPUS;
      mc->no_cdrom = true;
+    mc->default_ram_id = "ddr";
  }
static const TypeInfo versal_virt_machine_init_typeinfo = {





reply via email to

[Prev in Thread] Current Thread [Next in Thread]