Re: [PATCH 010/104] virtiofsd: Fix fuse_daemonize ignored return values

[Daniel P . Berrangé]

On Thu, Dec 12, 2019 at 04:37:30PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> QEMU's compiler enables warnings/errors for ignored values
> and the (void) trick used in the fuse code isn't enough.
> Turn all the return values into a return value on the function.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  tools/virtiofsd/helper.c | 33 ++++++++++++++++++++++-----------
>  1 file changed, 22 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <address@hidden>

> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index d8c42401a7..8afccfc15e 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -10,12 +10,10 @@
>   * See the file COPYING.LIB.
>   */
>  
> -#include "config.h"
>  #include "fuse_i.h"
>  #include "fuse_lowlevel.h"
>  #include "fuse_misc.h"
>  #include "fuse_opt.h"
> -#include "mount_util.h"
>  
>  #include <errno.h>
>  #include <limits.h>
> @@ -177,6 +175,7 @@ int fuse_parse_cmdline(struct fuse_args *args, struct 
> fuse_cmdline_opts *opts)
>  
>  int fuse_daemonize(int foreground)

Yay, 4th implementation of "daemonize" logic in QEMU codebase :-)

One day in the future it would be a nice idea to have a helper for
this that we can share across the system emulator, qemu guest agent,
qemu-nbd and virtiofsd. Not a requirement for this initial merge.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|