[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v3 09/29] plugins: Include trace/mem.h in api.c |
|
Date: |
Sat, 4 Jan 2020 08:59:19 +1100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
On 1/3/20 5:22 PM, Philippe Mathieu-Daudé wrote:
> Hi Richard,
>
> On 12/29/19 12:11 AM, Richard Henderson wrote:
>> Code movement in an upcoming patch will show that this file
>> was implicitly depending on trace/mem.h being included beforehand.
>
> Ah, it uses the TRACE_MEM_* macros from "trace/mem-internal.h", which is
> include by "trace/mem.h". OK.
>
> Which part requires "trace-root.h"? Isn't it "trace/mem-internal.h" that
> should
> include "trace-root.h"?
I don't know -- perhaps it's not required at all. I think I did a blind copy
of the trace related includes that were being removed.
r~