qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] display/gtk: get proper refreshrate


From: Gerd Hoffmann
Subject: Re: [PATCH v3] display/gtk: get proper refreshrate
Date: Tue, 7 Jan 2020 08:19:04 +0100

  Hi,

>  {
>      bool zoom_to_fit = false;
>  
> +    int refresh_rate_millihz = 0;

Please drop the blank line between the variable declarations.
Also there is no need to zero-initialize the variable ...

> +    refresh_rate_millihz = gdk_monitor_get_refresh_rate(monitor);

... as it is set unconditionally here.

> +    if (refresh_rate_millihz) {
> +        vc->gfx.dcl.update_interval = MILLISEC_PER_SEC /
> refresh_rate_millihz;

Patch is corrupted here, your mailer wrapped the line.
Best way to avoid this is to send patches using "git send-email".

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]