[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_w
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance |
Date: |
Tue, 7 Jan 2020 12:23:47 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Thu, Dec 12, 2019 at 04:38:59PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: piaojun <address@hidden>
>
> fuse_buf_writev() only handles the normal write in which src is buffer
> and dest is fd. Specially if src buffer represents guest physical
> address that can't be mapped by the daemon process, IO must be bounced
> back to the VMM to do it by fuse_buf_copy().
>
> Signed-off-by: Jun Piao <address@hidden>
> Suggested-by: Dr. David Alan Gilbert <address@hidden>
> Suggested-by: Stefan Hajnoczi <address@hidden>
> ---
> tools/virtiofsd/buffer.c | 23 +++++++++++++++++++----
> 1 file changed, 19 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
>
> diff --git a/tools/virtiofsd/buffer.c b/tools/virtiofsd/buffer.c
> index ae420c70c4..4875473785 100644
> --- a/tools/virtiofsd/buffer.c
> +++ b/tools/virtiofsd/buffer.c
> @@ -33,9 +33,7 @@ size_t fuse_buf_size(const struct fuse_bufvec *bufv)
> return size;
> }
>
> -__attribute__((unused))
> -static ssize_t fuse_buf_writev(fuse_req_t req,
Lets cull the fuse_req_t param in the previous patch
> - struct fuse_buf *out_buf,
> +static ssize_t fuse_buf_writev(struct fuse_buf *out_buf,
> struct fuse_bufvec *in_buf)
> {
> ssize_t res, i, j;
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 099/104] virtiofsd: use fuse_buf_writev to replace fuse_buf_write for better performance,
Daniel P . Berrangé <=