Re: [PATCH v2 5/5] tests/tcg: add user version of dumb-as-bricks semiconsole test

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 12/21/19 12:22 AM, Alex Bennée wrote:
>> +#if defined(__arm__)
>> +    register uintptr_t t asm("r0") = type;
>> +    register uintptr_t a0 asm("r1") = arg0;
>> +    asm("svc 0xab"
>> +        : "=r" (t)
>> +        : "r" (t), "r" (a0));
>
> This is the #ifdef __thumb__ svc code.  Are you enforcing that with
> command-line arguments?

No it is dealing with aarch64 vs 32 bit and the __arm__ is a compiler
symbol. 

>
> Might as well fix this, then test both arm and thumb.

I've enabled for Aarch64 just like the semihosting test.

>
>
> r~


-- 
Alex Bennée