[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH v2 1/1] s390x/event-facility.c: remove unneeded labels |
|
Date: |
Mon, 13 Jan 2020 17:02:22 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 08/01/2020 15.46, Daniel Henrique Barboza wrote:
> 'out' label from write_event_mask() and and write_event_data()
> can be replaced by 'return'.
>
> The 'out' label from read_event_data() can also be replaced.
> However, as suggested by Cornelia Huck, instead of simply
> replacing the 'out' label, let's also change the code flow
> a bit to make it clearer that sccb events are always handled
> regardless of the mask for unconditional reads, while selective
> reads are handled if the mask is valid.
>
> CC: Cornelia Huck <address@hidden>
> CC: Thomas Huth <address@hidden>
> CC: Halil Pasic <address@hidden>
> CC: Christian Borntraeger <address@hidden>
> Signed-off-by: Daniel Henrique Barboza <address@hidden>
Wow, that cleans up quite a bit of goto-spaghetti-code!
Reviewed-by: Thomas Huth <address@hidden>