Re: [PATCH 1/4] linux-user: Use `qemu_log' for non-strace logging

[Laurent Vivier]

Le 14/01/2020 à 04:01, Josh Kunz a écrit :
> This change introduces a new logging mask "LOG_USER", which is used for
> masking general user-mode logging. This change also switches all non-strace
> uses of `gemu_log' in linux-user/ to use `qemu_log_mask(LOG_USER, ...)'
> instead. This allows the user to easily log to a file, and to mask out
> these log messages if they desire.
> 
> Signed-off-by: Josh Kunz <address@hidden>
> ---
>  include/qemu/log.h        |  2 ++
>  linux-user/arm/cpu_loop.c |  5 ++--
>  linux-user/fd-trans.c     | 55 +++++++++++++++++++++++++--------------
>  linux-user/main.c         | 24 +++++++++++++++++
>  linux-user/syscall.c      | 30 ++++++++++++---------
>  linux-user/vm86.c         |  3 ++-
>  util/log.c                |  3 +++
>  7 files changed, 86 insertions(+), 36 deletions(-)

I think most of these log messages should use LOG_UNIMP, so no need for
a new flag.

Thanks,
Laurent