[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/86] hw:aspeed: drop warning and bogus ram_size fixup
From: |
Igor Mammedov |
Subject: |
[PATCH v2 09/86] hw:aspeed: drop warning and bogus ram_size fixup |
Date: |
Wed, 15 Jan 2020 16:06:24 +0100 |
It was useless to try fixup ram_size and print warning
on guest access to config register to begin with.
Now previous patch made sure that SDMC can not be realized
with invalid RAM size, so there is no case where warning
and not used ram_size fixup could be triggered.
So remove now dead code.
Signed-off-by: Igor Mammedov <address@hidden>
---
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
CC: address@hidden
---
hw/misc/aspeed_sdmc.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index b398e36..942b27a 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -219,17 +219,8 @@ static int aspeed_get_ram_feat(AspeedSDMCState *s)
{
AspeedSDMCClass *asc = ASPEED_SDMC_GET_CLASS(s);
int ram_mb = s->ram_size >> 20;
- gpointer val;
+ gpointer val = g_hash_table_lookup(asc->ram2feat, GINT_TO_POINTER(ram_mb));
- if (g_hash_table_contains(asc->ram2feat, GINT_TO_POINTER(ram_mb))) {
- val = g_hash_table_lookup(asc->ram2feat, GINT_TO_POINTER(ram_mb));
- return GPOINTER_TO_INT(val);
- }
-
- warn_report("Invalid RAM size 0x%" PRIx64 ". Using default %dM",
- s->ram_size, asc->fallback_ram_size);
- s->ram_size = asc->fallback_ram_size << 20;
- val = g_hash_table_lookup(asc->ram2feat, &asc->fallback_ram_size);
return GPOINTER_TO_INT(val);
}
--
2.7.4
- Re: [PATCH v2 03/86] machine: alias -mem-path and -mem-prealloc into memory-foo backend, (continued)
[PATCH v2 09/86] hw:aspeed: drop warning and bogus ram_size fixup,
Igor Mammedov <=
[PATCH v2 07/86] arm:aspeed: convert valid RAM sizes to data, Igor Mammedov, 2020/01/15
[PATCH v2 10/86] arm:aspeed: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 11/86] arm:collie: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 12/86] arm:cubieboard: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 13/86] arm:digic_boards: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 14/86] arm:highbank: use memdev for RAM, Igor Mammedov, 2020/01/15