[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 02/12] migration: Export the 'migration_incoming_setup' f
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH RFC 02/12] migration: Export the 'migration_incoming_setup' function and add the 'migrate_use_rdma_pin_all' function |
Date: |
Wed, 15 Jan 2020 18:57:03 +0000 |
User-agent: |
Mutt/1.13.0 (2019-11-30) |
* Zhimin Feng (address@hidden) wrote:
> From: fengzhimin <address@hidden>
>
> We need to call the 'migration_incoming_setup' function in migration/rdma.c,
> so it has to be changed to a global function.
>
> Signed-off-by: fengzhimin <address@hidden>
OK, but this should probably be split into two patches.
With a split;
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/migration.c | 11 ++++++++++-
> migration/migration.h | 2 ++
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index e98e236ef9..d9d73a5eac 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -518,7 +518,7 @@ fail:
> exit(EXIT_FAILURE);
> }
>
> -static void migration_incoming_setup(QEMUFile *f)
> +void migration_incoming_setup(QEMUFile *f)
> {
> MigrationIncomingState *mis = migration_incoming_get_current();
>
> @@ -2185,6 +2185,15 @@ bool migrate_use_multiRDMA(void)
> return s->enabled_capabilities[MIGRATION_CAPABILITY_MULTIRDMA];
> }
>
> +bool migrate_use_rdma_pin_all(void)
> +{
> + MigrationState *s;
> +
> + s = migrate_get_current();
> +
> + return s->enabled_capabilities[MIGRATION_CAPABILITY_RDMA_PIN_ALL];
> +}
> +
> bool migrate_use_multifd(void)
> {
> MigrationState *s;
> diff --git a/migration/migration.h b/migration/migration.h
> index bb488028a6..0a23375b2f 100644
> --- a/migration/migration.h
> +++ b/migration/migration.h
> @@ -265,6 +265,7 @@ struct MigrationState
>
> void migrate_set_state(int *state, int old_state, int new_state);
>
> +void migration_incoming_setup(QEMUFile *f);
> void migration_fd_process_incoming(QEMUFile *f);
> void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp);
> void migration_incoming_process(void);
> @@ -297,6 +298,7 @@ bool migrate_validate_uuid(void);
>
> bool migrate_auto_converge(void);
> bool migrate_use_multiRDMA(void);
> +bool migrate_use_rdma_pin_all(void);
> bool migrate_use_multifd(void);
> bool migrate_pause_before_switchover(void);
> int migrate_multifd_channels(void);
> --
> 2.19.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PATCH RFC 01/12] migration: Add multiRDMA capability support, (continued)
- [PATCH RFC 01/12] migration: Add multiRDMA capability support, Zhimin Feng, 2020/01/09
- [PATCH RFC 10/12] migration/rdma: use multiRDMA to send RAM block for rdma-pin-all mode, Zhimin Feng, 2020/01/09
- [PATCH RFC 12/12] migration/rdma: only register the virt-ram block for MultiRDMA, Zhimin Feng, 2020/01/09
- [PATCH RFC 02/12] migration: Export the 'migration_incoming_setup' function and add the 'migrate_use_rdma_pin_all' function, Zhimin Feng, 2020/01/09
- [PATCH RFC 07/12] migration/rdma: Be sure all channels are created, Zhimin Feng, 2020/01/09
- [PATCH RFC 05/12] migration/rdma: Create the multiRDMA channels, Zhimin Feng, 2020/01/09
- Re: [PATCH RFC 00/12] *** mulitple RDMA channels for migration ***, no-reply, 2020/01/09
- Re: [PATCH RFC 00/12] *** mulitple RDMA channels for migration ***, Dr. David Alan Gilbert, 2020/01/15