[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 18/86] arm:kzm: drop RAM size fixup
From: |
Chubb, Peter (Data61, Kensington NSW) |
Subject: |
Re: [PATCH v2 18/86] arm:kzm: drop RAM size fixup |
Date: |
Wed, 15 Jan 2020 19:58:51 +0000 |
>>>>> "Igor" == Igor Mammedov <address@hidden> writes:
Igor> If user provided non-sense RAM size, board will complain and
Igor> continue running with max RAM size supported. Also RAM is going
Igor> to be allocated by generic code, so it won't be possible for
Igor> board to fix things up for user.
Igor> Make it error message and exit to force user fix CLI, instead of
Igor> accepting non-sense CLI values.
I think this comment needs rewording a little. Maybe:
If the user provided too large a RAM size, the code used to
complain and trim it to the max size. Now tht RAM is allocated by
generic code, that's no longer possible, so generate an error and
exit instead.
Igor> /* Check the amount of memory is compatible with the SOC */
Igor> if (machine->ram_size > (FSL_IMX31_SDRAM0_SIZE +
Igor> FSL_IMX31_SDRAM1_SIZE)) {
Igor> - warn_report("RAM size " RAM_ADDR_FMT " above max supported, "
Igor> + error_report("RAM size " RAM_ADDR_FMT " above max supported, "
Igor> "reduced to %x", machine->ram_size,
Igor> FSL_IMX31_SDRAM0_SIZE + FSL_IMX31_SDRAM1_SIZE);
This needs to be changed so it doesn't say that the RAM size
is reduced, just what the maximum is. Maybe:
error_report("RAM size " RAM_ADDR_FMT " above max (%x) supported.",
machine->ram_size, FSL_IMX31_SDRAM0_SIZE +
FSL_IMX31_SDRAM1_SIZE);
Peter C
- [PATCH v2 10/86] arm:aspeed: use memdev for RAM, (continued)
- [PATCH v2 10/86] arm:aspeed: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 11/86] arm:collie: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 12/86] arm:cubieboard: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 13/86] arm:digic_boards: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 14/86] arm:highbank: use memdev for RAM, Igor Mammedov, 2020/01/15
- [PATCH v2 18/86] arm:kzm: drop RAM size fixup, Igor Mammedov, 2020/01/15
- Re: [PATCH v2 18/86] arm:kzm: drop RAM size fixup,
Chubb, Peter (Data61, Kensington NSW) <=
[PATCH v2 19/86] arm:kzm: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 17/86] arm:integratorcp: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 16/86] arm:imx25_pdk: use memdev for RAM, Igor Mammedov, 2020/01/15
[PATCH v2 15/86] arm:imx25_pdk: drop RAM size fixup, Igor Mammedov, 2020/01/15