[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked
From: |
Alex Bennée |
Subject: |
Re: [PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked |
Date: |
Mon, 20 Jan 2020 13:41:58 +0000 |
User-agent: |
mu4e 1.3.6; emacs 28.0.50 |
Richard Henderson <address@hidden> writes:
> We will want to be able to flush a tlb without resizing.
Reviewed-by: Alex Bennée <address@hidden>
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> accel/tcg/cputlb.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index eff427f137..e60e501334 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -228,12 +228,8 @@ static void tlb_mmu_resize_locked(CPUTLBDesc *desc,
> CPUTLBDescFast *fast)
> }
> }
>
> -static void tlb_flush_one_mmuidx_locked(CPUArchState *env, int mmu_idx)
> +static void tlb_mmu_flush_locked(CPUTLBDesc *desc, CPUTLBDescFast *fast)
> {
> - CPUTLBDesc *desc = &env_tlb(env)->d[mmu_idx];
> - CPUTLBDescFast *fast = &env_tlb(env)->f[mmu_idx];
> -
> - tlb_mmu_resize_locked(desc, fast);
> desc->n_used_entries = 0;
> desc->large_page_addr = -1;
> desc->large_page_mask = -1;
> @@ -242,6 +238,15 @@ static void tlb_flush_one_mmuidx_locked(CPUArchState
> *env, int mmu_idx)
> memset(desc->vtable, -1, sizeof(desc->vtable));
> }
>
> +static void tlb_flush_one_mmuidx_locked(CPUArchState *env, int mmu_idx)
> +{
> + CPUTLBDesc *desc = &env_tlb(env)->d[mmu_idx];
> + CPUTLBDescFast *fast = &env_tlb(env)->f[mmu_idx];
> +
> + tlb_mmu_resize_locked(desc, fast);
> + tlb_mmu_flush_locked(desc, fast);
> +}
> +
> static inline void tlb_n_used_entries_inc(CPUArchState *env, uintptr_t
> mmu_idx)
> {
> env_tlb(env)->d[mmu_idx].n_used_entries++;
--
Alex Bennée
- [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked, (continued)
- [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked, Richard Henderson, 2020/01/08
- [PATCH 7/9] cputlb: Partially merge tlb_dyn_init into tlb_init, Richard Henderson, 2020/01/08
- [PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked, Richard Henderson, 2020/01/08
- [PATCH 8/9] cputlb: Initialize tlbs as flushed, Richard Henderson, 2020/01/08
- [PATCH 9/9] cputlb: Hoist timestamp outside of loops over tlbs, Richard Henderson, 2020/01/08
- Re: [PATCH 0/9] cputlb: Various cleanups, Alistair Francis, 2020/01/20