[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 016/104] virtiofsd: Open vhost connection instead of mounting
From: |
Misono Tomohiro |
Subject: |
Re: [PATCH 016/104] virtiofsd: Open vhost connection instead of mounting |
Date: |
Tue, 21 Jan 2020 15:57:21 +0900 |
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> When run with vhost-user options we conect to the QEMU instead
> via a socket. Start this off by creating the socket.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
<snip>
> + /*
> + * Poison the fuse FD so we spot if we accidentally use it;
> + * DO NOT check for this value, check for fuse_lowlevel_is_virtio()
> + */
> + se->fd = 0xdaff0d11;
</snip>
As a result of this, se->fd now holds dummy fd.
So we should remove close(se->fd) in fuse_session_destroy():
https://gitlab.com/virtio-fs/qemu/blob/virtio-fs-dev/tools/virtiofsd/fuse_lowlevel.c#L2663
Reviewed-by: Misono Tomohiro <address@hidden>