[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry |
|
Date: |
Tue, 21 Jan 2020 13:15:08 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
On 18.01.20 20:09, Alberto Garcia wrote:
> When updating an L1 entry the qcow2 driver writes a (512-byte) sector
> worth of data to avoid a read-modify-write cycle. Instead of always
> writing 512 bytes we should follow the alignment requirements of the
> storage backend.
>
> (the only exception is when the alignment is larger than the cluster
> size because then we could be overwriting data after the L1 table)
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/qcow2-cluster.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates, Alberto Garcia, 2020/01/18
- [PATCH v3 2/5] qcow2: Tighten cluster_offset alignment assertions, Alberto Garcia, 2020/01/18
- [PATCH v3 4/5] qcow2: Don't require aligned offsets in qcow2_co_copy_range_from(), Alberto Garcia, 2020/01/18
- [PATCH v3 5/5] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value, Alberto Garcia, 2020/01/18
- [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry, Alberto Garcia, 2020/01/18
- Re: [PATCH v3 3/5] qcow2: Use bs->bl.request_alignment when updating an L1 entry,
Max Reitz <=
- [PATCH v3 1/5] qcow2: Don't round the L1 table allocation up to the sector size, Alberto Garcia, 2020/01/18
- Re: [PATCH v3 0/5] Misc BDRV_SECTOR_SIZE updates, Max Reitz, 2020/01/21