qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 01/20] softmmu: split off vl.c:main() into main.c


From: Stefan Hajnoczi
Subject: Re: [PATCH v7 01/20] softmmu: split off vl.c:main() into main.c
Date: Tue, 21 Jan 2020 16:26:59 +0000

On Mon, Jan 20, 2020 at 05:54:38AM +0000, Bulekov, Alexander wrote:
> @@ -3813,7 +3794,7 @@ int main(int argc, char **argv, char **envp)
>      set_memory_options(&ram_slots, &maxram_size, machine_class);
>  
>      os_daemonize();
> -    rcu_disable_atfork();
> +    /* rcu_disable_atfork(); */

In response to my question about this you said:

"Yes, though obviously it didn't make it into v6 :) I'm planning to just
check qtest_enabled(), since for now we are always using qtest."

Please resolve this in v8.

Lines shouldn't be commented out, especially not without an explanation
in the comments.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]