qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 097/109] virtiofsd: convert more fprintf and perror to use


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 097/109] virtiofsd: convert more fprintf and perror to use fuse log infra
Date: Wed, 22 Jan 2020 16:44:48 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 1/21/20 1:24 PM, Dr. David Alan Gilbert (git) wrote:
From: Eryu Guan <address@hidden>

Signed-off-by: Eryu Guan <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Misono Tomohiro <address@hidden>
---
  tools/virtiofsd/fuse_signals.c | 7 +++++--
  tools/virtiofsd/helper.c       | 9 ++++++---
  2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/tools/virtiofsd/fuse_signals.c b/tools/virtiofsd/fuse_signals.c
index 10a6f88088..5364cbe984 100644
--- a/tools/virtiofsd/fuse_signals.c
+++ b/tools/virtiofsd/fuse_signals.c
@@ -11,6 +11,7 @@
  #include "fuse_i.h"
  #include "fuse_lowlevel.h"
+#include <errno.h>
  #include <signal.h>
  #include <stdio.h>
  #include <stdlib.h>
@@ -46,13 +47,15 @@ static int set_one_signal_handler(int sig, void 
(*handler)(int), int remove)
      sa.sa_flags = 0;
if (sigaction(sig, NULL, &old_sa) == -1) {
-        perror("fuse: cannot get old signal handler");
+        fuse_log(FUSE_LOG_ERR, "fuse: cannot get old signal handler: %s\n",
+                 strerror(errno));
          return -1;
      }
if (old_sa.sa_handler == (remove ? handler : SIG_DFL) &&
          sigaction(sig, &sa, NULL) == -1) {
-        perror("fuse: cannot set signal handler");
+        fuse_log(FUSE_LOG_ERR, "fuse: cannot set signal handler: %s\n",
+                 strerror(errno));
          return -1;
      }
      return 0;
diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
index 781c47031c..a19959926c 100644
--- a/tools/virtiofsd/helper.c
+++ b/tools/virtiofsd/helper.c
@@ -208,7 +208,8 @@ int fuse_daemonize(int foreground)
          char completed;
if (pipe(waiter)) {
-            perror("fuse_daemonize: pipe");
+            fuse_log(FUSE_LOG_ERR, "fuse_daemonize: pipe: %s\n",
+                     strerror(errno));
              return -1;
          }
@@ -218,7 +219,8 @@ int fuse_daemonize(int foreground)
           */
          switch (fork()) {
          case -1:
-            perror("fuse_daemonize: fork");
+            fuse_log(FUSE_LOG_ERR, "fuse_daemonize: fork: %s\n",
+                     strerror(errno));
              return -1;
          case 0:
              break;
@@ -228,7 +230,8 @@ int fuse_daemonize(int foreground)
          }
if (setsid() == -1) {
-            perror("fuse_daemonize: setsid");
+            fuse_log(FUSE_LOG_ERR, "fuse_daemonize: setsid: %s\n",
+                     strerror(errno));
              return -1;
          }

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]