Re: [PULL v3 00/18] virtio, pc: fixes, features

[Michael S. Tsirkin]

On Wed, Jan 22, 2020 at 11:45:33PM -0800, address@hidden wrote:
> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems.

yes but they are fixed by a follow up patch :)

> See output below for
> more information:
> 
> Type: series
> Message-id: address@hidden
> Subject: [PULL v3 00/18] virtio, pc: fixes, features
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 2b8191c vhost: coding style fix
> 7bb1f74 i386:acpi: Remove _HID from the SMBus ACPI entry
> 5d5ae0b vhost: Only align sections for vhost-user
> 2fe690d vhost: Add names to section rounded warning
> 85f2aa9 vhost-vsock: delete vqs in vhost_vsock_unrealize to avoid memleaks
> ae724d7 virtio-scsi: convert to new virtio_delete_queue
> 32a8d7a virtio-scsi: delete vqs in unrealize to avoid memleaks
> ce15ad4 virtio-9p-device: convert to new virtio_delete_queue
> 3bdf076 virtio-9p-device: fix memleak in virtio_9p_device_unrealize
> 01fb3bc bios-tables-test: document expected file update
> 021497c acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command
> 8df7461 acpi: cpuhp: spec: add typical usecases
> f37ff6b acpi: cpuhp: introduce 'Command data 2' field
> 9c2e2a3 acpi: cpuhp: spec: clarify store into 'Command data' when 'Command 
> field' == 0
> 31632fb acpi: cpuhp: spec: fix 'Command data' description
> 8833b70 acpi: cpuhp: spec: clarify 'CPU selector' register usage and 
> endianness
> 59529c2 tests: q35: MCH: add default SMBASE SMRAM lock test
> ab4ab8f q35: implement 128K SMRAM at default SMBASE address
> 
> === OUTPUT BEGIN ===
> 1/18 Checking commit ab4ab8fed8c2 (q35: implement 128K SMRAM at default 
> SMBASE address)
> 2/18 Checking commit 59529c21dc20 (tests: q35: MCH: add default SMBASE SMRAM 
> lock test)
> 3/18 Checking commit 8833b70f38a3 (acpi: cpuhp: spec: clarify 'CPU selector' 
> register usage and endianness)
> 4/18 Checking commit 31632fb04976 (acpi: cpuhp: spec: fix 'Command data' 
> description)
> 5/18 Checking commit 9c2e2a3c55cf (acpi: cpuhp: spec: clarify store into 
> 'Command data' when 'Command field' == 0)
> 6/18 Checking commit f37ff6b0328f (acpi: cpuhp: introduce 'Command data 2' 
> field)
> 7/18 Checking commit 8df7461f8e9c (acpi: cpuhp: spec: add typical usecases)
> 8/18 Checking commit 021497cfae81 (acpi: cpuhp: add CPHP_GET_CPU_ID_CMD 
> command)
> 9/18 Checking commit 01fb3bc40a44 (bios-tables-test: document expected file 
> update)
> WARNING: line over 80 characters
> #23: FILE: tests/qtest/bios-tables-test.c:20:
> + * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve 
> conflicts
> 
> total: 0 errors, 1 warnings, 38 lines checked
> 
> Patch 9/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 10/18 Checking commit 3bdf076c6da1 (virtio-9p-device: fix memleak in 
> virtio_9p_device_unrealize)
> 11/18 Checking commit ce15ad428cde (virtio-9p-device: convert to new 
> virtio_delete_queue)
> 12/18 Checking commit 32a8d7a0b553 (virtio-scsi: delete vqs in unrealize to 
> avoid memleaks)
> 13/18 Checking commit ae724d76b8ed (virtio-scsi: convert to new 
> virtio_delete_queue)
> 14/18 Checking commit 85f2aa9f8aa0 (vhost-vsock: delete vqs in 
> vhost_vsock_unrealize to avoid memleaks)
> 15/18 Checking commit 2fe690da39c7 (vhost: Add names to section rounded 
> warning)
> 16/18 Checking commit 5d5ae0b9e061 (vhost: Only align sections for vhost-user)
> ERROR: trailing whitespace
> #49: FILE: hw/virtio/vhost.c:554:
> +    if (dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER) {   $
> 
> WARNING: line over 80 characters
> #64: FILE: hw/virtio/vhost.c:569:
> +        trace_vhost_region_add_section_aligned(section->mr->name, mrs_gpa, 
> mrs_size,
> 
> total: 1 errors, 1 warnings, 43 lines checked
> 
> Patch 16/18 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 17/18 Checking commit 7bb1f74b40e9 (i386:acpi: Remove _HID from the SMBus 
> ACPI entry)
> 18/18 Checking commit 2b8191c490a6 (vhost: coding style fix)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to address@hidden