[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH REPOST v3 24/80] arm/omap_sx1: use memdev for RAM

From: Andrew Jones
Subject: Re: [PATCH REPOST v3 24/80] arm/omap_sx1: use memdev for RAM
Date: Thu, 23 Jan 2020 14:12:05 +0100

On Thu, Jan 23, 2020 at 12:37:49PM +0100, Igor Mammedov wrote:
> memory_region_allocate_system_memory() API is going away, so
> replace it with memdev allocated MemoryRegion. The later is
> initialized by generic code, so board only needs to opt in
> to memdev scheme by providing
>   MachineClass::default_ram_id
> and using MachineState::ram instead of manually initializing
> RAM memory region.
> PS:
>  while at it add check for user supplied RAM size and error
>  out if it mismatches board expected value.
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> v2:
>   * fix format string causing build failure on 32-bit host
>     (Philippe Mathieu-Daudé <address@hidden>)
> CC: address@hidden
> CC: address@hidden
> CC: address@hidden
> ---
>  hw/arm/omap_sx1.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)

I don't know anything about omap_sx1, but I promised Igor to put
another pair of eyes on his changes. Looks fine to me.

Reviewed-by: Andrew Jones <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]