[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str, in

From: Paolo Bonzini
Subject: Re: [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}()
Date: Thu, 23 Jan 2020 15:34:03 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 23/01/20 12:39, Marc-André Lureau wrote:
> Hi
> On Thu, Jan 23, 2020 at 3:29 PM Paolo Bonzini <address@hidden> wrote:
>> This patch caught my attention because of the typo in the function, but
> Ah! a french "défaut".

I suspected that. :)

>> I also noticed that get_default is never set to anything but
>> object_property_get_defval.
>> What do you think about removing the method and just relying on defval?
>> In practice there would be a new patch that squashes 7, 10 and the thing
>> after my signature.
> Indeed, we could remove the get_default callback. I can't find the
> reason I added it now.
> Are you resending the series then?

I have already sent a pull request.  In the end even
object_property_get_default was only used once so I just inlined it and
dropped patch 7.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]