Re: [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture

[Cornelia Huck]

On Thu, 23 Jan 2020 11:36:55 -0200
Wainer dos Santos Moschetta <address@hidden> wrote:

> On 1/23/20 9:48 AM, Cornelia Huck wrote:
> > On Wed, 22 Jan 2020 23:32:46 +0100
> > Philippe Mathieu-Daudé <address@hidden> wrote:
> >  
> >> Running on mainstream KVM architectures, we get:
> >>
> >> - Aarch64
> >>
> >>    Timeout.
> >>
> >>    job.log:
> >>    -------
> >>    No machine specified, and there is no default
> >>    Use -machine help to list supported machines  
> > The code probably needs to be made more clever to find the machines to
> > run?
> >  
> >> - MIPS:
> >>
> >>     (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: argument of 
> >> type 'NoneType' is not iterable (0.14 s)
> >>
> >>    job.log:
> >>    -------
> >>    Could not load MIPS bios 'mipsel_bios.bin', and no -kernel argument was 
> >> specified  
> > Probably needs some hint from mips folks how this can be set up.
> >  
> >> - PowerPC
> >>
> >>     (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: invalid 
> >> literal for int() with base 10: 'sxxm' (0.16 s)
> >>
> >>    job.log:
> >>    -------  
> >>    >>> {'execute': 'query-machines'}  
> >>    <<< {'return': [{'hotpluggable-cpus': True, 'name': 
> >> 'pseries-2.12-sxxm', 'numa-mem-supported': True, 'default-cpu-type': 
> >> 'power8_v2.0-powerpc64-cpu', 'cpu-max': 1024, 'deprecated': False}, ...  
> > This seems to be because the machine type parsing code cannot deal with
> > the format used here.  
> 
> 
> Indeed, looking at the comments in code the parser was meant for PC types.
> 
> Is there a way to obtain the machine type version other than parsing its 
> name? If not, wouldn't be useful for management apps have that 
> information returned with 'query-machines'?

The question would be "What version?". The pseries machine type the
code chokes upon above has an additional suffix. Not all machine types
are versioned, obviously, and we don't have an uniform way to build
machine type names, either.

If I understand this test correctly, the idea is to distinguish between
"version that defaults the feature to off" and "version that defaults
the feature to on". So, the pseries machine with the extra suffix from
above and the one without would basically be the same 2.12 compatible
machine (both in the first bucket). For other tests, those two machines
might be very different, though.

tl;dr "version" might not be well-defined enough.

> 
> - Wainer
> 
> >> - S390X:
> >>
> >>     (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: invalid 
> >> literal for int() with base 10: 'virtio' (0.14 s)
> >>
> >>    job.log:
> >>    -------
> >>    Traceback (most recent call last):
> >>      File "virtio_seg_max_adjust.py", line 139, in test_machine_types
> >>        if self.seg_max_adjust_enabled(m):
> >>      File "virtio_seg_max_adjust.py", line 113, in seg_max_adjust_enabled
> >>        major = int(ver[0])
> >>    ValueError: invalid literal for int() with base 10: 'virtio'  
> >>    >>> {'execute': 'query-machines'}  
> >>    <<< {'return': [{'hotpluggable-cpus': True, 'name': 
> >> 's390-ccw-virtio-4.0', 'numa-mem-supported': False, 'default-cpu-type': 
> >> 'qemu-s390x-cpu', 'cpu-max': 248, 'deprecated': False}, ...  
> > Same here.