Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
9d7e4e6 monitor/hmp: Prefer to use hmp_handle_error for error reporting in 
block hmp commands
a549971 add 'error' prefix to vreport
7c7da3a monitor: Move hmp_drive_add_node to block-hmp-cmds.c
a2a0265 monitor/hmp: move hmp_info_block* to block-hmp-cmds.c
d7f13de monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c
c067499 monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c
f5fab94 monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c
4cb26f9 monitor/hmp: move hmp_block_job* to block-hmp-cmds.c
97953d5 monitor/hmp: move hmp_drive_mirror and hmp_drive_backup to 
block-hmp-cmds.c
00dc3e8 monitor/hmp: move hmp_drive_del and hmp_commit to block-hmp-cmds.c
a4aa184 monitor/hmp: rename device-hotplug.c to block/monitor/block-hmp-cmds.c
d76374a monitor/hmp: uninline add_init_drive
13decc9 usb/dev-storage: remove unused include

=== OUTPUT BEGIN ===
1/13 Checking commit 13decc9a539d (usb/dev-storage: remove unused include)
2/13 Checking commit d76374a8829d (monitor/hmp: uninline add_init_drive)
3/13 Checking commit a4aa1842d39b (monitor/hmp: rename device-hotplug.c to 
block/monitor/block-hmp-cmds.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit 00dc3e8c0cc5 (monitor/hmp: move hmp_drive_del and 
hmp_commit to block-hmp-cmds.c)
WARNING: Block comments use a leading /* on a separate line
#81: FILE: block/monitor/block-hmp-cmds.c:119:
+    /* If this BlockBackend has a device attached to it, its refcount will be

total: 0 errors, 1 warnings, 234 lines checked

Patch 4/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/13 Checking commit 97953d583c25 (monitor/hmp: move hmp_drive_mirror and 
hmp_drive_backup to block-hmp-cmds.c)
6/13 Checking commit 4cb26f9c9af1 (monitor/hmp: move hmp_block_job* to 
block-hmp-cmds.c)
7/13 Checking commit f5fab9454aca (monitor/hmp: move hmp_snapshot_* to 
block-hmp-cmds.c)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: block/monitor/block-hmp-cmds.c:294:
+        /* In the future, if 'snapshot-file' is not specified, the snapshot

WARNING: Block comments use * on subsequent lines
#30: FILE: block/monitor/block-hmp-cmds.c:295:
+        /* In the future, if 'snapshot-file' is not specified, the snapshot
+           will be taken internally. Today it's actually required. */

WARNING: Block comments use a trailing */ on a separate line
#30: FILE: block/monitor/block-hmp-cmds.c:295:
+           will be taken internally. Today it's actually required. */

total: 0 errors, 3 warnings, 120 lines checked

Patch 7/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/13 Checking commit c06749935535 (monitor/hmp: move hmp_nbd_server* to 
block-hmp-cmds.c)
WARNING: Block comments use a leading /* on a separate line
#60: FILE: block/monitor/block-hmp-cmds.c:363:
+    /* Then try adding all block devices.  If one fails, close all and

total: 0 errors, 1 warnings, 217 lines checked

Patch 8/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/13 Checking commit d7f13ded16b4 (monitor/hmp: move remaining hmp_block* 
functions to block-hmp-cmds.c)
WARNING: Block comments use a leading /* on a separate line
#75: FILE: block/monitor/block-hmp-cmds.c:468:
+    /* qmp_block_set_io_throttle has separate parameters for the

WARNING: Block comments use a trailing */ on a separate line
#77: FILE: block/monitor/block-hmp-cmds.c:470:
+     * version has only one, so we must decide which one to pass. */

ERROR: "foo* bar" should be "foo *bar"
#105: FILE: block/monitor/block-hmp-cmds.c:498:
+    const char* device = qdict_get_str(qdict, "device");

ERROR: "foo* bar" should be "foo *bar"
#106: FILE: block/monitor/block-hmp-cmds.c:499:
+    const char* command = qdict_get_str(qdict, "command");

total: 2 errors, 2 warnings, 359 lines checked

Patch 9/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/13 Checking commit a2a0265c0910 (monitor/hmp: move hmp_info_block* to 
block-hmp-cmds.c)
WARNING: line over 80 characters
#67: FILE: block/monitor/block-hmp-cmds.c:593:
+        if (info->has_io_status && info->io_status != 
BLOCK_DEVICE_IO_STATUS_OK) {

WARNING: Block comments use a leading /* on a separate line
#381: FILE: block/monitor/block-hmp-cmds.c:907:
+            /* The ID is not guaranteed to be the same on all images, so

total: 0 errors, 2 warnings, 845 lines checked

Patch 10/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/13 Checking commit 7c7da3a311a3 (monitor: Move hmp_drive_add_node to 
block-hmp-cmds.c)
12/13 Checking commit a549971b349f (add 'error' prefix to vreport)
ERROR: trailing whitespace
#51: FILE: tests/qemu-iotests/026.out:6:
+Event: l1_update; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#62: FILE: tests/qemu-iotests/026.out:16:
+Event: l1_update; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#79: FILE: tests/qemu-iotests/026.out:30:
+Event: l1_update; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#90: FILE: tests/qemu-iotests/026.out:40:
+Event: l1_update; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#107: FILE: tests/qemu-iotests/026.out:54:
+Event: l2_load; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#116: FILE: tests/qemu-iotests/026.out:70:
+Event: l2_load; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#125: FILE: tests/qemu-iotests/026.out:86:
+Event: l2_load; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#134: FILE: tests/qemu-iotests/026.out:102:
+Event: l2_load; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#143: FILE: tests/qemu-iotests/026.out:118:
+Event: l2_update; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#154: FILE: tests/qemu-iotests/026.out:128:
+Event: l2_update; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#171: FILE: tests/qemu-iotests/026.out:142:
+Event: l2_update; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#182: FILE: tests/qemu-iotests/026.out:152:
+Event: l2_update; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#199: FILE: tests/qemu-iotests/026.out:166:
+Event: l2_alloc_write; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#210: FILE: tests/qemu-iotests/026.out:176:
+Event: l2_alloc_write; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#227: FILE: tests/qemu-iotests/026.out:190:
+Event: l2_alloc_write; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#238: FILE: tests/qemu-iotests/026.out:200:
+Event: l2_alloc_write; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#255: FILE: tests/qemu-iotests/026.out:214:
+Event: write_aio; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#266: FILE: tests/qemu-iotests/026.out:224:
+Event: write_aio; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#283: FILE: tests/qemu-iotests/026.out:238:
+Event: write_aio; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#294: FILE: tests/qemu-iotests/026.out:248:
+Event: write_aio; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#311: FILE: tests/qemu-iotests/026.out:262:
+Event: refblock_load; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#322: FILE: tests/qemu-iotests/026.out:272:
+Event: refblock_load; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#339: FILE: tests/qemu-iotests/026.out:286:
+Event: refblock_load; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#350: FILE: tests/qemu-iotests/026.out:296:
+Event: refblock_load; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#367: FILE: tests/qemu-iotests/026.out:310:
+Event: refblock_update_part; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#378: FILE: tests/qemu-iotests/026.out:320:
+Event: refblock_update_part; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#395: FILE: tests/qemu-iotests/026.out:334:
+Event: refblock_update_part; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#406: FILE: tests/qemu-iotests/026.out:344:
+Event: refblock_update_part; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#423: FILE: tests/qemu-iotests/026.out:358:
+Event: refblock_alloc; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#434: FILE: tests/qemu-iotests/026.out:368:
+Event: refblock_alloc; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#451: FILE: tests/qemu-iotests/026.out:382:
+Event: refblock_alloc; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#462: FILE: tests/qemu-iotests/026.out:392:
+Event: refblock_alloc; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#479: FILE: tests/qemu-iotests/026.out:406:
+Event: cluster_alloc; errno: 5; imm: off; once: on; write $

ERROR: trailing whitespace
#488: FILE: tests/qemu-iotests/026.out:416:
+Event: cluster_alloc; errno: 5; imm: off; once: off; write $

ERROR: trailing whitespace
#497: FILE: tests/qemu-iotests/026.out:426:
+Event: cluster_alloc; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#506: FILE: tests/qemu-iotests/026.out:436:
+Event: cluster_alloc; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#515: FILE: tests/qemu-iotests/026.out:449:
+Event: refblock_alloc_hookup; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#526: FILE: tests/qemu-iotests/026.out:459:
+Event: refblock_alloc_hookup; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#543: FILE: tests/qemu-iotests/026.out:473:
+Event: refblock_alloc_write; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#554: FILE: tests/qemu-iotests/026.out:483:
+Event: refblock_alloc_write; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#571: FILE: tests/qemu-iotests/026.out:497:
+Event: refblock_alloc_write_blocks; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#582: FILE: tests/qemu-iotests/026.out:507:
+Event: refblock_alloc_write_blocks; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#599: FILE: tests/qemu-iotests/026.out:521:
+Event: refblock_alloc_write_table; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#610: FILE: tests/qemu-iotests/026.out:531:
+Event: refblock_alloc_write_table; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#627: FILE: tests/qemu-iotests/026.out:545:
+Event: refblock_alloc_switch_table; errno: 28; imm: off; once: on; write $

ERROR: trailing whitespace
#638: FILE: tests/qemu-iotests/026.out:555:
+Event: refblock_alloc_switch_table; errno: 28; imm: off; once: off; write $

ERROR: trailing whitespace
#781: FILE: tests/qemu-iotests/049.out:107:
+qemu-img: error: Invalid image size specified! You may use k, M, G, T, P or E 
suffixes for $

ERROR: trailing whitespace
#793: FILE: tests/qemu-iotests/049.out:116:
+qemu-img: error: Invalid image size specified! You may use k, M, G, T, P or E 
suffixes for $

total: 48 errors, 0 warnings, 3053 lines checked

Patch 12/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/13 Checking commit 9d7e4e6ebe5d (monitor/hmp: Prefer to use hmp_handle_error 
for error reporting in block hmp commands)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden