[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images
Date: Mon, 27 Jan 2020 12:05:57 -0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/27/20 8:38 AM, Thomas Huth wrote:
On 25/01/2020 19.38, Philippe Mathieu-Daudé wrote:
On 1/25/20 5:43 PM, Thomas Huth wrote:
On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote:
On 1/24/20 3:03 PM, Thomas Huth wrote:
The 2018 edition of the QEMU advent calendar 2018 featured Linux images
for various non-x86 machines. We can use them for a boot tests in our
acceptance test suite.
Excellent idea!

Let's also make sure that we build the corresponding machines in Travis,
and while we're there, drop the superfluous --python parameter (python3
is now the only supported version anyway).
I'd rather see this change as another commit.
I thought so, too, often it is good to separate stuff into separate
commits, but in this case, it's not source code but just the CI yml
file, and the change is really trivial, so it rather sounds like
superfluous churn to me in this case to do it in a separate patch...

Yes, please, removal of --python was in my wish list.

Signed-off-by: Thomas Huth <address@hidden>
   .travis.yml                            |  2 +-
   tests/acceptance/boot_linux_console.py | 96 ++++++++++++++++++++++++++
   2 files changed, 97 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 6c1038a0f1..73ca12c921 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -268,7 +268,7 @@ matrix:
         # Acceptance (Functional) tests
       - env:
-        - CONFIG="--python=/usr/bin/python3

+        -

Perhaps use MAIN_SOFTMMU_TARGETS in only append the other targets, like:

Not sure ... while it is a nice way to shorten the line here, it adds a
dependency to that variable ... and MAIN_SOFTMMU_TARGETS has been changed
a couple of times during the course of time, so we might risk to lose
some testing coverage here in case someone removes a target from
MAIN_SOFTMMU_TARGETS but forgets to add it here again...? I think we
should better use the explicit list here instead.
Maybe related: "Split enterprise vs. hobbyist acceptance test job"
I guess naming/splitting is hard in this case ... many targets contain
both, "enterprise" and "hobbyist" machines ... and as long as the Travis
job runs reasonably fast, it's also not really necessary to split it.
The only real ugliness is the very long line - I haven't found a way yet
to correctly wrap this in the YML file to multiple lines .... does
anybody know how to do this in YML?

Try to break the lines with '\' (note: next line should not be indented). It worked out on following code:

[wainersm@localhost ~]$ cat /tmp/foo.py
import yaml

    - env:
      - CONFIG="-target-list=x86_64-softmmu,\
[wainersm@localhost ~]$ python3 /tmp/foo.py
{'matrix': {'include': [{'env': ['CONFIG="-target-list=x86_64-softmmu,mips-softmmu,mips64el-softmmu"']}]}}

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]