|
From: | Wainer dos Santos Moschetta |
Subject: | Re: [PATCH] tests/acceptance: Add a test for the canon-a1100 machine |
Date: | Tue, 28 Jan 2020 12:01:38 -0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/28/20 10:16 AM, Thomas Huth wrote:
On 27/01/2020 21.56, Philippe Mathieu-Daudé wrote:Hey Wainer, On 1/27/20 6:45 PM, Wainer dos Santos Moschetta wrote:On 1/27/20 1:41 PM, Philippe Mathieu-Daudé wrote:On 1/27/20 4:39 PM, Thomas Huth wrote:On 27/01/2020 16.18, Philippe Mathieu-Daudé wrote:On 1/27/20 3:41 PM, Thomas Huth wrote:The canon-a1100 machine can be used with the Barebox firmware. The QEMU Advent Calendar 2018 features a pre-compiled image which we can use for testing. Signed-off-by: Thomas Huth <address@hidden> --- tests/acceptance/machine_arm_canon-a1100.py | 33 +++++++++++++++++++++What is the reason for not adding this case in boot_linux_console suite?Because there are too many tests in this file and it became hardly maintainable. Also it is easier to add a 'F:' entry in the MAINTAINERS file to each machine section.
Maybe it reached an inflection point and deserves to be split among files and directories...
Additionally, this is not a test with a Linux kernel, it uses the Barebox firmware instead. So boot_*linux*_console.py sounds like the wrong place for this test.
OK, makes complete sense.One last comment about this new file. To not look like boring I let pylint say that for me :) :
[wainersm@localhost qemu]$ pylint-3 tests/acceptance/machine_arm_canon-a1100.py
************* Module machine_arm_canon-a1100tests/acceptance/machine_arm_canon-a1100.py:1:0: C0103: Module name "machine_arm_canon-a1100" doesn't conform to snake_case naming style (invalid-name)
With that fix: Reviewed-by: Wainer dos Santos Moschetta <address@hidden> Tested-by: Wainer dos Santos Moschetta <address@hidden> Thanks, Wainer
Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |