[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 0/7] ARM virt: Add NVDIMM support
From: |
Shameerali Kolothum Thodi |
Subject: |
RE: [PATCH v2 0/7] ARM virt: Add NVDIMM support |
Date: |
Wed, 29 Jan 2020 10:44:16 +0000 |
Hi Eric,
> -----Original Message-----
> From: Auger Eric [mailto:address@hidden]
> Sent: 28 January 2020 15:29
> To: Shameerali Kolothum Thodi <address@hidden>;
> address@hidden; address@hidden; address@hidden
> Cc: address@hidden; address@hidden; address@hidden;
> address@hidden; xuwei (O) <address@hidden>;
> address@hidden; Linuxarm <address@hidden>
> Subject: Re: [PATCH v2 0/7] ARM virt: Add NVDIMM support
>
> Hi Shameer,
>
> On 1/17/20 6:45 PM, Shameer Kolothum wrote:
> > This series adds NVDIMM support to arm/virt platform.
> > The series reuses some of the patches posted by Eric
> > in his earlier attempt here[1].
> >
> > Patch #1 is a fix to the Guest reboot issue on NVDIMM
> > hot add case described here[2] and patch #2 is another
> > fix to the nvdimm aml issue discussed here[3].
> >
> > I have done a basic sanity testing of NVDIMM deviecs
> > with Guest booting with both ACPI and DT. Further testing
> > is always welcome.
> >
> > Please let me know your feedback.
>
>
> With this version, I do not get the former spurious warning reported on v1.
>
> I can see the nvdimm device topology using ndctl. So it looks fine to me.
Thanks for giving it a spin and confirming.
> Unfortunately we cannot test with DAX as kernel dependencies are not yet
> resolved yet but this is an independent problem.
True. I did previously test DAX with "arm64/mm: Enable memory hot remove"
Patch series and that seems to work fine.
Cheers,
Shameer
> Thanks
>
> Eric
> >
> > Thanks,
> > Shameer
> >
> > [1] https://patchwork.kernel.org/cover/10830777/
> > [2] https://patchwork.kernel.org/patch/11154757/
> > [3] https://patchwork.kernel.org/cover/11174959/
> >
> > v1 --> v2
> > -Reworked patch #1 and now fix is inside qemu_ram_resize().
> > -Added patch #2 to fix the nvdim aml issue.
> > -Dropped support to DT cold plug.
> > -Updated test_acpi_virt_tcg_memhp() with pc-dimm and nvdimms(patch
> #7)
> >
> > Kwangwoo Lee (2):
> > nvdimm: Use configurable ACPI IO base and size
> > hw/arm/virt: Add nvdimm hot-plug infrastructure
> >
> > Shameer Kolothum (5):
> > exec: Fix for qemu_ram_resize() callback
> > hw/acpi/nvdimm: Fix for NVDIMM incorrect DSM output buffer length
> > hw/arm/virt: Add nvdimm hotplug support
> > tests: Update ACPI tables list for upcoming arm/virt test changes
> > tests/bios-tables-test: Update arm/virt memhp test
> >
> > docs/specs/acpi_hw_reduced_hotplug.rst | 1 +
> > exec.c | 36 +++++++----
> > hw/acpi/generic_event_device.c | 13 ++++
> > hw/acpi/nvdimm.c | 68
> +++++++++++++++++----
> > hw/arm/Kconfig | 1 +
> > hw/arm/virt-acpi-build.c | 6 ++
> > hw/arm/virt.c | 35 +++++++++--
> > hw/i386/acpi-build.c | 6 ++
> > hw/i386/acpi-build.h | 3 +
> > hw/i386/pc_piix.c | 2 +
> > hw/i386/pc_q35.c | 2 +
> > hw/mem/Kconfig | 2 +-
> > include/exec/ram_addr.h | 5 +-
> > include/hw/acpi/generic_event_device.h | 1 +
> > include/hw/arm/virt.h | 1 +
> > include/hw/mem/nvdimm.h | 3 +
> > tests/data/acpi/virt/NFIT.memhp | 0
> > tests/data/acpi/virt/SSDT.memhp | 0
> > tests/qtest/bios-tables-test-allowed-diff.h | 5 ++
> > tests/qtest/bios-tables-test.c | 9 ++-
> > 20 files changed, 163 insertions(+), 36 deletions(-)
> > create mode 100644 tests/data/acpi/virt/NFIT.memhp
> > create mode 100644 tests/data/acpi/virt/SSDT.memhp
> >