qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend


From: Igor Mammedov
Subject: Re: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend
Date: Mon, 3 Feb 2020 10:49:17 +0100

On Fri, 31 Jan 2020 08:28:02 -0800 (PST)
address@hidden wrote:

> Patchew URL: https://patchew.org/QEMU/address@hidden/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PATCH v4 00/80] refactor main RAM allocation to use hostmem backend
> Message-id: address@hidden
[...]
> 1/80 Checking commit 60461983c933 (numa: remove deprecated -mem-path fallback 
> to anonymous RAM)
> 2/80 Checking commit 5762ea41ea77 (machine: introduce memory-backend property)
> 3/80 Checking commit bcce25a8e595 (machine: alias -mem-path and -mem-prealloc 
> into memory-foo backend)
> 4/80 Checking commit 700389660de4 (machine: introduce convenience 
> MachineState::ram)
> 5/80 Checking commit 690a30507aa5 (initialize MachineState::ram in NUMA case)
> 6/80 Checking commit 32f83261cd0d (vl.c: move -m parsing after memory 
> backends has been processed)
> 7/80 Checking commit de3c2ca6c609 (vl.c: ensure that ram_size matches size of 
> machine.memory-backend)
> 8/80 Checking commit 8de04fd7210c (alpha/dp264: use memdev for RAM)
> ERROR: spaces required around that '*' (ctx:WxV)
> #30: FILE: hw/alpha/alpha_sys.h:14:
> +PCIBus *typhoon_init(MemoryRegion *, ISABus **, qemu_irq *, AlphaCPU *[4],

false positive
                                                                       ^
> 
> total: 1 errors, 0 warnings, 49 lines checked
> 
> Patch 8/80 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 

[...]

> 64/80 Checking commit c0f1fddf078c (ppc/{ppc440_bamboo, sam460ex}: drop RAM 
> size fixup)
> 65/80 Checking commit c68dc4f3f534 (ppc/{ppc440_bamboo, sam460ex}: use memdev 
> for RAM)
> WARNING: Block comments use a leading /* on a separate line
> #50: FILE: hw/ppc/ppc4xx_devs.c:669:
> +/* Split RAM between SDRAM banks.

will fix it if I have to respin.

> 
> total: 0 errors, 1 warnings, 103 lines checked
> 
> Patch 65/80 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
[...]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]