[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] audio: proper support for float samples in mixeng

From: Zoltán Kővágó
Subject: Re: [RFC PATCH] audio: proper support for float samples in mixeng
Date: Mon, 3 Feb 2020 21:38:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.9) Goanna/4.4 Interlink/52.9.7282

On 2020-02-03 11:00, Peter Maydell wrote:
On Sun, 2 Feb 2020 at 19:39, Kővágó, Zoltán <address@hidden> wrote:

This adds proper support for float samples in mixeng by adding a new
audio format for it.

Limitations: only native endianness is supported.

Could you explain a bit more what this limitation means, please?
In general QEMU behaviour shouldn't depend on the endianness
of the host, ie we should byteswap where necessary.

None of the virtual sound cards support float samples (it looks like most of them only support 8 and 16 bit, only hda supports 32 bit), it is only used for the audio backends (i.e. host side). In audiodev_to_audsettings we set endianness to AUDIO_HOST_ENDIANNESS, so audio backends should always use native endian.

So this limitation should only cause problems when an audio backend overrides the endian setting. Wavcapture does it, but it does not support float. Alsa, sdl, puleaudio and oss can also do it if for some weird reason it acquires a stream with a different endianness than requested.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]