[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" fr
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0 |
Date: |
Tue, 4 Feb 2020 01:35:40 -0500 |
On Tue, Feb 04, 2020 at 09:43:20AM +0800, Heyi Guo wrote:
> The sub device "RP0" under PCI0 in ACPI/DSDT does not contain any
> method or property other than "_ADR", so it is safe to remove it.
>
> Signed-off-by: Heyi Guo <address@hidden>
> Acked-by: "Michael S. Tsirkin" <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> Cc: Peter Maydell <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Igor Mammedov <address@hidden>
> Cc: Shannon Zhao <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> ---
> hw/arm/virt-acpi-build.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index bd5f771e9b..9f4c7d1889 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -317,10 +317,6 @@ static void acpi_dsdt_add_pci(Aml *scope, const
> MemMapEntry *memmap,
> aml_append(method, aml_return(buf));
> aml_append(dev, method);
>
> - Aml *dev_rp0 = aml_device("%s", "RP0");
> - aml_append(dev_rp0, aml_name_decl("_ADR", aml_int(0)));
> - aml_append(dev, dev_rp0);
> -
> Aml *dev_res0 = aml_device("%s", "RES0");
> aml_append(dev_res0, aml_name_decl("_HID", aml_string("PNP0C02")));
> crs = aml_resource_template();
> --
> 2.19.1
- [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/03
- [PATCH v3 6/7] arm/acpi: simplify the description of PCI _CRS, Heyi Guo, 2020/02/03
- [PATCH v3 5/7] arm/acpi: fix duplicated _UID of PCI interrupt link devices, Heyi Guo, 2020/02/03
- [PATCH v3 3/7] arm/virt/acpi: remove _ADR from devices identified by _HID, Heyi Guo, 2020/02/03
- [PATCH v3 1/7] bios-tables-test: prepare to change ARM virt ACPI DSDT, Heyi Guo, 2020/02/03
- [PATCH v3 4/7] arm/acpi: fix PCI _PRT definition, Heyi Guo, 2020/02/03
- [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0, Heyi Guo, 2020/02/03
- Re: [PATCH v3 2/7] arm/virt/acpi: remove meaningless sub device "RP0" from PCI0,
Michael S. Tsirkin <=
- [PATCH v3 7/7] virt/acpi: update golden masters for DSDT update, Heyi Guo, 2020/02/03
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Heyi Guo, 2020/02/09
- Re: [PATCH v3 0/7] Some cleanup in arm/virt/acpi, Peter Maydell, 2020/02/11