qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 3/3] target/mips: Separate FPU-related helpers into their own file
Date: Tue, 4 Feb 2020 09:30:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/4/20 9:06 AM, Aleksandar Markovic wrote:
> > For clarity and easier maintenence, create target/mips/fpu_helper.c, and
 > > move all FPU-related content form target/mips/op_helper.c to that file.
 > >
 > > Signed-off-by: Aleksandar Markovic <address@hidden>
 > > Reviewed-by: Aleksandar Rikalo <address@hidden>
> > Message-Id: <address@hidden>
 > > ---
 > > target/mips/Makefile.objs | 2 +-
> > target/mips/fpu_helper.c | 1911 +++++++++++++++++++++++++++++++++++++++++++++ > > target/mips/op_helper.c | 1877 --------------------------------------------
 > > 3 files changed, 1912 insertions(+), 1878 deletions(-)
 > > create mode 100644 target/mips/fpu_helper.c
 > >
 > > diff --git a/target/mips/Makefile.objs b/target/mips/Makefile.objs
 > > index 3ca2bde..91eb691 100644
 > > --- a/target/mips/Makefile.objs
 > > +++ b/target/mips/Makefile.objs
 > > @@ -1,5 +1,5 @@
 > > obj-y += translate.o cpu.o gdbstub.o helper.o
 > > -obj-y += op_helper.o cp0_helper.o
 > > +obj-y += op_helper.o cp0_helper.o fpu_helper.o
 > > obj-y += dsp_helper.o lmi_helper.o msa_helper.o
 > > obj-$(CONFIG_SOFTMMU) += mips-semi.o
 > > obj-$(CONFIG_SOFTMMU) += machine.o cp0_timer.o
 > > diff --git a/target/mips/fpu_helper.c b/target/mips/fpu_helper.c
 > > new file mode 100644
 > > index 0000000..0d5769e
 > > --- /dev/null
 > > +++ b/target/mips/fpu_helper.c
 > > @@ -0,0 +1,1911 @@
 > > +/*
 > > + * Helpers for emulation of CP0-related MIPS instructions.
 >
 > Isn't it "FPU"?
 >

Damn, I did the change, but forgot to do "commit --amend", and that passed unnoticed during the rest of procedure.

I just sent PULL v2.

This was not a big deal, we could have updated the comment with another patch. I was just wondering. Thanks for caring to send a quick v2!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]