Re: [PATCH v2] fence: introduce a file-based self-fence mechanism

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing 
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      hw/block/block.o
  CC      hw/block/cdrom.o
  CC      hw/block/hd-geometry.o
/tmp/qemu-test/src/backends/file-fence.c:44:5: error: unknown type name 
'timer_t'
     timer_t ktimer;
     ^~~~~~~
/tmp/qemu-test/src/backends/file-fence.c: In function 'timer_update':
/tmp/qemu-test/src/backends/file-fence.c:68:15: error: implicit declaration of 
function 'timer_settime'; did you mean 'timer_get'? 
[-Werror=implicit-function-declaration]
         err = timer_settime(ff->ktimer, 0, &its, NULL);
               ^~~~~~~~~~~~~
               timer_get
/tmp/qemu-test/src/backends/file-fence.c:68:15: error: nested extern 
declaration of 'timer_settime' [-Werror=nested-externs]
/tmp/qemu-test/src/backends/file-fence.c: In function 'ktimer_tear':
/tmp/qemu-test/src/backends/file-fence.c:103:15: error: implicit declaration of 
function 'timer_delete'; did you mean 'timer_del'? 
[-Werror=implicit-function-declaration]
         err = timer_delete(ff->ktimer);
               ^~~~~~~~~~~~
               timer_del
/tmp/qemu-test/src/backends/file-fence.c:103:15: error: nested extern 
declaration of 'timer_delete' [-Werror=nested-externs]
/tmp/qemu-test/src/backends/file-fence.c:105:20: error: assignment to 'int' 
from 'void *' makes integer from pointer without a cast [-Werror=int-conversion]
         ff->ktimer = NULL;
                    ^
/tmp/qemu-test/src/backends/file-fence.c: In function 'ktimer_setup':
/tmp/qemu-test/src/backends/file-fence.c:114:12: error: variable 'sev' has 
initializer but incomplete type
     struct sigevent sev = {
            ^~~~~~~~
/tmp/qemu-test/src/backends/file-fence.c:115:10: error: 'struct sigevent' has 
no member named 'sigev_notify'
         .sigev_notify = SIGEV_SIGNAL,
          ^~~~~~~~~~~~
/tmp/qemu-test/src/backends/file-fence.c:115:25: error: 'SIGEV_SIGNAL' 
undeclared (first use in this function); did you mean 'SIG_IGN'?
         .sigev_notify = SIGEV_SIGNAL,
                         ^~~~~~~~~~~~
                         SIG_IGN
/tmp/qemu-test/src/backends/file-fence.c:115:25: note: each undeclared 
identifier is reported only once for each function it appears in
/tmp/qemu-test/src/backends/file-fence.c:115:25: error: excess elements in 
struct initializer [-Werror]
/tmp/qemu-test/src/backends/file-fence.c:115:25: note: (near initialization for 
'sev')
/tmp/qemu-test/src/backends/file-fence.c:116:10: error: 'struct sigevent' has 
no member named 'sigev_signo'
         .sigev_signo = ff->signal ? ff->signal : SIGKILL,
          ^~~~~~~~~~~
/tmp/qemu-test/src/backends/file-fence.c:116:50: error: 'SIGKILL' undeclared 
(first use in this function); did you mean 'SIGILL'?
         .sigev_signo = ff->signal ? ff->signal : SIGKILL,
                                                  ^~~~~~~
                                                  SIGILL
/tmp/qemu-test/src/backends/file-fence.c:116:24: error: excess elements in 
struct initializer [-Werror]
         .sigev_signo = ff->signal ? ff->signal : SIGKILL,
                        ^~
/tmp/qemu-test/src/backends/file-fence.c:116:24: note: (near initialization for 
'sev')
/tmp/qemu-test/src/backends/file-fence.c:114:21: error: storage size of 'sev' 
isn't known
     struct sigevent sev = {
                     ^~~
/tmp/qemu-test/src/backends/file-fence.c:123:11: error: implicit declaration of 
function 'timer_create'; did you mean 'timer_update'? 
[-Werror=implicit-function-declaration]
     err = timer_create(CLOCK_MONOTONIC, &sev, &ff->ktimer);
           ^~~~~~~~~~~~
           timer_update
/tmp/qemu-test/src/backends/file-fence.c:123:11: error: nested extern 
declaration of 'timer_create' [-Werror=nested-externs]
/tmp/qemu-test/src/backends/file-fence.c:114:21: error: unused variable 'sev' 
[-Werror=unused-variable]
     struct sigevent sev = {
                     ^~~
/tmp/qemu-test/src/backends/file-fence.c: In function 'file_fence_set_signal':
/tmp/qemu-test/src/backends/file-fence.c:248:22: error: 'SIGQUIT' undeclared 
(first use in this function); did you mean 'SIGABRT'?
         ff->signal = SIGQUIT;
                      ^~~~~~~
                      SIGABRT
/tmp/qemu-test/src/backends/file-fence.c:253:22: error: 'SIGKILL' undeclared 
(first use in this function); did you mean 'SIGILL'?
         ff->signal = SIGKILL;
                      ^~~~~~~
                      SIGILL
/tmp/qemu-test/src/backends/file-fence.c: In function 'file_fence_get_signal':
/tmp/qemu-test/src/backends/file-fence.c:267:10: error: 'SIGKILL' undeclared 
(first use in this function); did you mean 'SIGILL'?
     case SIGKILL:
          ^~~~~~~
          SIGILL
/tmp/qemu-test/src/backends/file-fence.c:269:10: error: 'SIGQUIT' undeclared 
(first use in this function); did you mean 'SIGABRT'?
     case SIGQUIT:
          ^~~~~~~
          SIGABRT
/tmp/qemu-test/src/backends/file-fence.c: In function 
'file_fence_instance_init':
/tmp/qemu-test/src/backends/file-fence.c:343:36: error: 
'OBJ_PROP_FLAG_READWRITE' undeclared (first use in this function); did you mean 
'OBJ_PROP_LINK_DIRECT'?
                                    OBJ_PROP_FLAG_READWRITE, &error_abort);
                                    ^~~~~~~~~~~~~~~~~~~~~~~
                                    OBJ_PROP_LINK_DIRECT
/tmp/qemu-test/src/backends/file-fence.c:342:5: error: too many arguments to 
function 'object_property_add_uint32_ptr'
     object_property_add_uint32_ptr(obj, "qtimeout", &ff->qtimeout,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/qemu-test/src/include/qom/object_interfaces.h:4,
---
/tmp/qemu-test/src/include/qom/object.h:1709:6: note: declared here
 void object_property_add_uint32_ptr(Object *obj, const char *name,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/qemu-test/src/backends/file-fence.c:344:5: error: too many arguments to 
function 'object_property_add_uint32_ptr'
     object_property_add_uint32_ptr(obj, "ktimeout", &ff->ktimeout,
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/qemu-test/src/include/qom/object_interfaces.h:4,
---
  CC      hw/block/fdc.o
  CC      hw/block/m25p80.o
  CC      hw/block/nand.o
make: *** [/tmp/qemu-test/src/rules.mak:69: backends/file-fence.o] Error 1
make: *** Waiting for unfinished jobs....
  CC      hw/block/pflash_cfi01.o
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', 
'--label', 'com.qemu.instance.uuid=3831efbbac3f42a78230b2ca17f24b5c', '-u', 
'1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', 
'-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 
'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', 
'/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', 
'/var/tmp/patchew-tester-tmp-5cvmkgft/src/docker-src.2020-02-05-05.12.43.31686:/var/tmp/qemu:z,ro',
 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit 
status 2.
filter=--filter=label=com.qemu.instance.uuid=3831efbbac3f42a78230b2ca17f24b5c
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-5cvmkgft/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    2m16.282s
user    0m8.876s


The full log is available at
http://patchew.org/logs/address@hidden/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden